Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing tests for an ICE #124427

Merged
merged 1 commit into from
Apr 27, 2024
Merged

Add missing tests for an ICE #124427

merged 1 commit into from
Apr 27, 2024

Conversation

gurry
Copy link
Contributor

@gurry gurry commented Apr 27, 2024

Fixes #122191

@rustbot
Copy link
Collaborator

rustbot commented Apr 27, 2024

r? @nnethercote

rustbot has assigned @nnethercote.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 27, 2024
@matthiaskrgr
Copy link
Member

thanks!
@bors r+ rollup

@bors
Copy link
Contributor

bors commented Apr 27, 2024

📌 Commit fc73b4c has been approved by matthiaskrgr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 27, 2024
@matthiaskrgr matthiaskrgr mentioned this pull request Apr 27, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 27, 2024
@bors
Auto merge of rust-lang#124428 - matthiaskrgr:rollup-sk5z4z8, r=matth…
35194e7 
…iaskrgr

Rollup of 3 pull requests

Successful merges:

 - rust-lang#124382 (ast: Generalize item kind visiting)
 - rust-lang#124387 (thread_local: be excruciatingly explicit in dtor code)
 - rust-lang#124427 (Add missing tests for an ICE)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 9a6bfc7 into rust-lang:master Apr 27, 2024
10 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Apr 27, 2024
@rust-timer
Unrolled build for rust-lang#124427
f4a2d24 
Rollup merge of rust-lang#124427 - gurry:122191-unhandled-type, r=matthiaskrgr

Add missing tests for an ICE

Fixes rust-lang#122191
@rustbot rustbot added this to the 1.79.0 milestone Apr 27, 2024
@gurry gurry deleted the 122191-unhandled-type branch April 27, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nnethercote nnethercote

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.79.0
Development

Successfully merging this pull request may close these issues.

ICE: unhandled type: {type error}
5 participants
@gurry @rustbot @matthiaskrgr @bors @nnethercote