remove the TyDesc from TypedArena #12444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| } | ||
| let mut start = self.start(); | ||
| for _ in range(0, len) { |
There was a problem hiding this comment.
Do these loops actually optimise out for non-dtor types?
There was a problem hiding this comment.
Yes, Vec<T> does the same thing. I do want to provide a better way of doing this than read_ptr to make the code clearer and reduce the pre-optimization bloat a bit though.
There was a problem hiding this comment.
if std::unstable::intrinsics::needs_drop::<T>() {
for _ in range(0, len) { ... }
}
This prevents generating visit glue when using a TypedArena. The problem still exists for the untyped Arena.
bors
added a commit
that referenced
this pull request
Feb 23, 2014
This prevents generating visit glue when using a TypedArena. The problem still exists for the untyped Arena.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 25, 2022
fix: parsing of `?` opt-out trait bounds fixes rust-lang#12442
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jun 27, 2024
…xendoo Avoid emitting `assigning_clones` when cloned data borrows from the place to clone into Fixes rust-lang#12444 Fixes rust-lang#12460 Fixes rust-lang#12749 Fixes rust-lang#12757 Fixes rust-lang#12929 I think the documentation for the function should describe what- and how this is fixing the issues well. It avoids emitting a warning when the data being cloned borrows from the place to clone into, which is information that we can get from `PossibleBorrowerMap`. Unfortunately, it is a tiny bit tedious to match on the MIR like that and I'm not sure if this is possibly relying a bit too much on the exact MIR lowering for assignments. Things left to do: - [x] Handle place projections (or verify that they work as expected) - [x] Handle non-`Drop` types changelog: [`assigning_clones`]: avoid warning when the suggestion would lead to a borrow-check error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents generating visit glue when using a TypedArena. The problem
still exists for the untyped Arena.