Reduce the size of a rust install slightly #12448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are only ever used with LTO, so there's no need for reading them to be speedy.
You rarely want to statically link against librustc and friends, so there's no real reason to install the rlib version of these libraries, especially because the rlibs are massive.
|
What's the size after this? Has creating a lot of small libs greatly increased our total binary size? |
|
For OSX, this takes the size of an installation from 351MB to 177MB |
bors
added a commit
that referenced
this pull request
Feb 23, 2014
Two optimizations: 1. Compress `foo.bc` in each rlib with `flate`. These are just taking up space and are only used with LTO, no need for LTO to be speedy. 2. Stop install `librustc.rlib` and friends, this is a *huge* source of bloat. There's no need for us to install static libraries for these components. cc #12440
Ah, yes, a small 50% reduction in size. ;P (Nice work!) |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 18, 2022
…on, r=Veykril feat: Autocomplete Cargo-defined env vars in `env!` and `option_env!` (rust-lang#12448) Closes rust-lang#12448 Important to know: - Variables are taken from https://doc.rust-lang.org/cargo/reference/environment-variables.html and hardcoded as a const array. - For the sake of simplicity I didn't include the autocompletion of `CARGO_BIN_EXE_<name>` and `OUT_DIR` since it would require information about build.rs and binary name. If somebody knows an easy way of obtaining them I can add those vars as well :)
matthiaskrgr
pushed a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 21, 2024
[`single_match`]: Fix duplicate diagnostics Relates to rust-lang#12379 edit two test file `tests/ui/single_match_else.rs` `tests/ui/single_match.rs` those two test file point to the same lint --- changelog: [`single_match`] Fix duplicate diagnostics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two optimizations:
foo.bcin each rlib withflate. These are just taking up space and are only used with LTO, no need for LTO to be speedy.librustc.rliband friends, this is a huge source of bloat. There's no need for us to install static libraries for these components.cc #12440