Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tidy check for test revisions that are mentioned but not declared #124706

Merged
merged 3 commits into from
May 9, 2024
Merged

Tidy check for test revisions that are mentioned but not declared #124706

merged 3 commits into from
May 9, 2024

Commits on May 9, 2024

  1. Include the line number in tidy's iter_header

    @Zalathar
    Zalathar committed May 9, 2024
    Configuration menu
    Copy the full SHA
    1fbabc6 View commit details
    Browse the repository at this point in the history

  2. Tidy check for test revisions that are mentioned but not declared 

    If a `[revision]` name appears in a test header directive or error annotation,
but isn't declared in the `//@ revisions:` header, that is almost always a
mistake.

In cases where a revision needs to be temporarily disabled, adding it to an
`//@ unused-revision-names:` header will suppress these checks for that name.

Adding the wildcard name `*` to the unused list will suppress these checks for
the entire file.
    @Zalathar
    Zalathar committed May 9, 2024
    Configuration menu
    Copy the full SHA
    be590d3 View commit details
    Browse the repository at this point in the history

  3. Fix test problems discovered by the revision check 

    Most of these changes either add revision names that were apparently missing,
or explicitly mark a revision name as currently unused.
    @Zalathar
    Zalathar committed May 9, 2024
    Configuration menu
    Copy the full SHA
    14d56e8 View commit details
    Browse the repository at this point in the history