Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check if x test tests missing any test directory #124969

Merged
merged 3 commits into from
May 11, 2024
Merged

check if x test tests missing any test directory #124969

merged 3 commits into from
May 11, 2024

Conversation

onur-ozkan
Copy link
Member

Add a unit test to ensure we don't skip any test directories for x test tests in the future.

@rustbot
Copy link
Collaborator

rustbot commented May 10, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels May 10, 2024
@onur-ozkan onur-ozkan mentioned this pull request May 10, 2024
Merged
@rust-log-analyzer

This comment has been minimized.

Sign in to view
onur-ozkan added 3 commits May 10, 2024 17:37
@onur-ozkan
check if x test tests missing any test directory
c9fb74e 
Signed-off-by: onur-ozkan <work@onurozkan.dev>
@onur-ozkan
remap missing path tests/crashes to tests
569e547 
Signed-off-by: onur-ozkan <work@onurozkan.dev>
@onur-ozkan
add "tidy-alphabetical" check on "tests" remap list
0a0b40a 
Signed-off-by: onur-ozkan <work@onurozkan.dev>
@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented May 11, 2024

📌 Commit 0a0b40a has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 11, 2024
@bors
Copy link
Contributor

bors commented May 11, 2024

⌛ Testing commit 0a0b40a with merge 5bfea35...

bors added a commit to rust-lang-ci/rust that referenced this pull request May 11, 2024
@bors
Auto merge of rust-lang#124969 - onur-ozkan:test-tests-remap, r=Mark-…
5bfea35 
…Simulacrum

check if `x test tests` missing any test directory

Add a unit test to ensure we don't skip any test directories for `x test tests` in the future.
@rust-log-analyzer
Copy link
Collaborator

The job armhf-gnu failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@bors
Copy link
Contributor

bors commented May 11, 2024

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 11, 2024
@onur-ozkan
Copy link
Member Author

--- stderr -------------------------------
thread 'main' panicked at src/tools/remote-test-client/src/main.rs:310:9:
client.read_exact(&mut header) failed with Connection reset by peer (os error 104)
note: run with RUST_BACKTRACE=1 environment variable to display a backtrace

Suspicious and not related. @bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 11, 2024
@matthiaskrgr matthiaskrgr mentioned this pull request May 11, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 11, 2024
@bors
Auto merge of rust-lang#125010 - matthiaskrgr:rollup-270pck3, r=matth…
686bfc4 
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#124928 (Stabilize `byte_slice_trim_ascii` for `&[u8]`/`&str`)
 - rust-lang#124954 (Document proper usage of `fmt::Error` and `fmt()`'s `Result`.)
 - rust-lang#124969 (check if `x test tests` missing any test directory)
 - rust-lang#124978 (Handle Deref expressions in invalid_reference_casting)
 - rust-lang#125005 (Miri subtree update)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 7d7a182 into rust-lang:master May 11, 2024
6 of 7 checks passed
@rustbot rustbot added this to the 1.80.0 milestone May 11, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request May 11, 2024
@rust-timer
Unrolled build for rust-lang#124969
823a653 
Rollup merge of rust-lang#124969 - onur-ozkan:test-tests-remap, r=Mark-Simulacrum

check if `x test tests` missing any test directory

Add a unit test to ensure we don't skip any test directories for `x test tests` in the future.
@onur-ozkan onur-ozkan deleted the test-tests-remap branch May 11, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klensy klensy klensy left review comments

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
1.80.0
Development

Successfully merging this pull request may close these issues.
6 participants
@onur-ozkan @rustbot @rust-log-analyzer @Mark-Simulacrum @bors @klensy