Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uplift FnSig into rustc_type_ir (redux) #125170

Merged
merged 1 commit into from
May 16, 2024
Merged

Uplift FnSig into rustc_type_ir (redux) #125170

merged 1 commit into from
May 16, 2024

Conversation

compiler-errors
Copy link
Member

@compiler-errors compiler-errors commented May 16, 2024 •
edited
Loading

Since the last one got so messed up with try build.

#125157 (comment)

r? lcnr

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 16, 2024
@compiler-errors
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 16, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request May 16, 2024
@bors
Auto merge of rust-lang#125170 - compiler-errors:uplift-fn-sig-2, r=<…
9156367 
…try>

Uplift `FnSig` into `rustc_type_ir` (redux)

Since the last one got so messed up with `try` build.

r? lcnr
@bors
Copy link
Contributor

bors commented May 16, 2024

⌛ Trying commit 9d0b5be with merge 9156367...

compiler-errors
compiler-errors commented May 16, 2024
View reviewed changes
compiler/rustc_type_ir/src/inherent.rs Outdated
}

pub trait Abi<I: Interner<Abi = Self>>: Copy + Debug + Hash + Eq {
// is `extern "Rust"`?
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update this still

@bors
Copy link
Contributor

bors commented May 16, 2024

☀️ Try build successful - checks-actions
Build commit: 9156367 (91563676c30543d6bc1931af0fe66e05706f9b1d)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (9156367): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 1.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 1.1% [1.1%, 1.1%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 1.1% [1.1%, 1.1%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 678.078s -> 679.272s (0.18%)
Artifact size: 316.18 MiB -> 316.10 MiB (-0.03%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 16, 2024
@compiler-errors
Copy link
Member Author

@bors r=lcnr rollup

@bors
Copy link
Contributor

bors commented May 16, 2024

📌 Commit 312ba4d has been approved by lcnr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 16, 2024
@matthiaskrgr matthiaskrgr mentioned this pull request May 16, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 16, 2024
@bors
Auto merge of rust-lang#125179 - matthiaskrgr:rollup-wkdwoaj, r=matth…
97bf25c 
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#124871 (Don't ICE because recomputing overflow goals during find_best_leaf_obligation causes inference side-effects)
 - rust-lang#125018 (Update linker-plugin-lto.md to include LLVM 18)
 - rust-lang#125130 (rustdoc-json-types: Document `Id`)
 - rust-lang#125170 (Uplift `FnSig` into `rustc_type_ir` (redux))
 - rust-lang#125172 (Fix assertion when attempting to convert `f16` and `f128` with `as`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit a8a3117 into rust-lang:master May 16, 2024
6 checks passed
@rustbot rustbot added this to the 1.80.0 milestone May 16, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request May 16, 2024
@rust-timer
Unrolled build for rust-lang#125170
4308224 
Rollup merge of rust-lang#125170 - compiler-errors:uplift-fn-sig-2, r=lcnr

Uplift `FnSig` into `rustc_type_ir` (redux)

Since the last one got so messed up with `try` build.

rust-lang#125157 (comment)

r? lcnr
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lcnr lcnr

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.80.0
Development

Successfully merging this pull request may close these issues.
5 participants
@compiler-errors @rust-timer @bors @lcnr @rustbot