Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove more #[macro_use] extern crate tracing #125434

Merged
merged 15 commits into from
May 23, 2024
Merged

Remove more #[macro_use] extern crate tracing #125434

merged 15 commits into from
May 23, 2024

Conversation

nnethercote
Copy link
Contributor

Because explicit importing of macros via use items is nicer (more standard and readable) than implicit importing via #[macro_use]. Continuing the work from #124511 and #124914.

r? @jackh726

@rustbot rustbot added A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 23, 2024
@rustbot
Copy link
Collaborator

rustbot commented May 23, 2024

Some changes occurred in match lowering

cc @Nadrieril

Some changes occurred to the CTFE / Miri engine

cc @rust-lang/miri

Some changes occurred to the CTFE / Miri engine

cc @rust-lang/miri

Some changes occurred in coverage instrumentation.

cc @Zalathar

rustc_error_messages was changed

cc @davidtwco, @compiler-errors, @TaKO8Ki

Some changes occurred in rustc_ty_utils::consts.rs

cc @BoxyUwU

changes to the core type system

cc @compiler-errors, @lcnr

Some changes occurred in match checking

cc @Nadrieril

@nnethercote
Copy link
Contributor Author

Note: choosing where to insert use tracing::{...} lines is a pain due to the wide variety of use section styles. I generally tried to do something sensible. I'm looking into making rustfmt be more opinionated to avoid these kinds of decisions in the future.

@jackh726
Copy link
Member

@bors r+ rollup=never

@bors
Copy link
Contributor

bors commented May 23, 2024

📌 Commit edde136 has been approved by jackh726

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 23, 2024
@nnethercote nnethercote mentioned this pull request May 23, 2024
Closed
3 tasks
@bors
Copy link
Contributor

bors commented May 23, 2024

☔ The latest upstream changes (presumably #125359) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 23, 2024
@nnethercote
Remove #[macro_use] extern crate tracing from rustc_ty_utils.
bbe4efd
@nnethercote
Remove #[macro_use] extern crate tracing from rustc_error_messages.
448fc75
@nnethercote
Remove #[macro_use] extern crate tracing from rustc_passes.
7252923
@nnethercote
Remove #[macro_use] extern crate tracing from rustc_interface.
a7cd7bb
@nnethercote
Remove #[macro_use] extern crate tracing from rustc_incremental.
c4bdd29
@nnethercote
Remove #[macro_use] extern crate tracing from rustc_lint.
c7da1a5
@nnethercote
Remove #[macro_use] extern crate tracing from rustc_const_eval.
7a5d814
@nnethercote
Remove #[macro_use] extern crate tracing from rustc_monomorphize.
70e964a
@nnethercote
Remove #[macro_use] extern crate tracing from rustc_metadata.
d787fb0
@nnethercote
Remove #[macro_use] extern crate tracing from rustc_mir_build.
2539364
@nnethercote
Remove #[macro_use] extern crate tracing from rustc_parse.
bb364fe
@nnethercote
Remove #[macro_use] extern crate tracing from rustc_mir_dataflow.
9287aed
@nnethercote
Remove #[macro_use] extern crate tracing from rustc_codegen_llvm.
8e94226
@nnethercote
Remove #[macro_use] extern crate tracing from rustc_codegen_ssa.
8ae0694
@nnethercote
Remove #[macro_use] extern crate tracing from rustc_middle.
e9a59db
@nnethercote
Copy link
Contributor Author

I rebased.

@bors r=jackh726

@bors
Copy link
Contributor

bors commented May 23, 2024

📌 Commit e9a59db has been approved by jackh726

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 23, 2024
@bors
Copy link
Contributor

bors commented May 23, 2024

⌛ Testing commit e9a59db with merge 8679004...

@bors
Copy link
Contributor

bors commented May 23, 2024

☀️ Test successful - checks-actions
Approved by: jackh726
Pushing 8679004 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 23, 2024
@bors bors merged commit 8679004 into rust-lang:master May 23, 2024
7 checks passed
@rustbot rustbot added this to the 1.80.0 milestone May 23, 2024
@bors bors mentioned this pull request May 24, 2024
Merged
@nnethercote nnethercote deleted the rm-more-extern-tracing branch May 24, 2024 00:34
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (8679004): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 0.5% [0.4%, 0.9%] 7
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 674.256s -> 671.784s (-0.37%)
Artifact size: 315.73 MiB -> 315.72 MiB (-0.00%)

@nnethercote nnethercote mentioned this pull request Aug 29, 2024
Merged
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Aug 31, 2024
@workingjubilee
Rollup merge of rust-lang#129767 - nnethercote:rm-extern-crate-tracin…
b49ba78 
…g-4, r=jieyouxu

Remove `#[macro_use] extern crate tracing`, round 4

Because explicit importing of macros via use items is nicer (more standard and readable) than implicit importing via #[macro_use]. Continuing the work from rust-lang#124511, rust-lang#124914, and rust-lang#125434. After this PR no `rustc_*` crates use `#[macro_use] extern crate tracing` except for `rustc_codegen_gcc` which is a special case and I will do separately.

r? `@jieyouxu`
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Aug 31, 2024
@matthiaskrgr
Rollup merge of rust-lang#129767 - nnethercote:rm-extern-crate-tracin…
0a7f781 
…g-4, r=jieyouxu

Remove `#[macro_use] extern crate tracing`, round 4

Because explicit importing of macros via use items is nicer (more standard and readable) than implicit importing via #[macro_use]. Continuing the work from rust-lang#124511, rust-lang#124914, and rust-lang#125434. After this PR no `rustc_*` crates use `#[macro_use] extern crate tracing` except for `rustc_codegen_gcc` which is a special case and I will do separately.

r? ``@jieyouxu``
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Aug 31, 2024
@matthiaskrgr
Rollup merge of rust-lang#129767 - nnethercote:rm-extern-crate-tracin…
7d025bb 
…g-4, r=jieyouxu

Remove `#[macro_use] extern crate tracing`, round 4

Because explicit importing of macros via use items is nicer (more standard and readable) than implicit importing via #[macro_use]. Continuing the work from rust-lang#124511, rust-lang#124914, and rust-lang#125434. After this PR no `rustc_*` crates use `#[macro_use] extern crate tracing` except for `rustc_codegen_gcc` which is a special case and I will do separately.

r? ```@jieyouxu```
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Aug 31, 2024
@rust-timer
Unrolled build for rust-lang#129767
4f0a0da 
Rollup merge of rust-lang#129767 - nnethercote:rm-extern-crate-tracing-4, r=jieyouxu

Remove `#[macro_use] extern crate tracing`, round 4

Because explicit importing of macros via use items is nicer (more standard and readable) than implicit importing via #[macro_use]. Continuing the work from rust-lang#124511, rust-lang#124914, and rust-lang#125434. After this PR no `rustc_*` crates use `#[macro_use] extern crate tracing` except for `rustc_codegen_gcc` which is a special case and I will do separately.

r? ```@jieyouxu```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jackh726 jackh726

Labels
A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.80.0
Development

Successfully merging this pull request may close these issues.
5 participants
@nnethercote @rustbot @jackh726 @bors @rust-timer