Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in cargo-specifics.md #125494

Closed
wants to merge 1 commit into from
Closed

Conversation

cakebaker
Copy link
Contributor

This PR fixes three typos in cargo-specifics.md.

@rustbot
Copy link
Collaborator

rustbot commented May 24, 2024

r? @JohnTitor

rustbot has assigned @JohnTitor.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 24, 2024
@lqd
Copy link
Member

lqd commented May 24, 2024

@@ -37,11 +37,11 @@ implementation detail and is therefor not documented in Cargo, we therefor do th

*See the [`[lints]` section in the Cargo book][cargo-lints-table] for more details.*

When using a staticlly known custom config (ie. not dependant on a build-script), Cargo provides
When using a statically known custom config (ie. not dependant on a build-script), Cargo provides
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here, it's probably even

Suggested change
When using a statically known custom config (ie. not dependant on a build-script), Cargo provides
When using a statically known custom config (ie. not dependent on a build-script), Cargo provides

@ehuss
Copy link
Contributor

ehuss commented Jun 3, 2024

r? ehuss

@rustbot rustbot assigned ehuss and unassigned JohnTitor Jun 3, 2024
@ehuss
Copy link
Contributor

ehuss commented Jun 5, 2024

Closing in favor of #126048 which contains the additional edits in order to get this before beta. Thanks @cakebaker!

@ehuss ehuss closed this Jun 5, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jun 5, 2024
Fix typos in cargo-specifics.md

This fixes some wording in cargo-specifics.md.

This is based on rust-lang#125494 with some additional edits.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jun 6, 2024
Fix typos in cargo-specifics.md

This fixes some wording in cargo-specifics.md.

This is based on rust-lang#125494 with some additional edits.
@cakebaker cakebaker deleted the patch-1 branch June 6, 2024 05:15
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jun 6, 2024
Rollup merge of rust-lang#126048 - ehuss:cargo-specfics-fixes, r=ehuss

Fix typos in cargo-specifics.md

This fixes some wording in cargo-specifics.md.

This is based on rust-lang#125494 with some additional edits.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants