Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert proc_macro_back_compat lint to an unconditional error. #125596

Merged
merged 3 commits into from
Jun 4, 2024
Merged

Convert proc_macro_back_compat lint to an unconditional error. #125596

merged 3 commits into from
Jun 4, 2024

Commits on May 27, 2024

  1. Remove a stray comment that shouldn't be here.

    @nnethercote
    nnethercote committed May 27, 2024
    Configuration menu
    Copy the full SHA
    d6d2ff0 View commit details
    Browse the repository at this point in the history

  2. Use let chains in pretty_printing_compatibility_hack. 

    To reduce indentation and improve readability.
    @nnethercote
    nnethercote committed May 27, 2024
    Configuration menu
    Copy the full SHA
    3607cee View commit details
    Browse the repository at this point in the history

  3. Convert proc_macro_back_compat lint to an unconditional error. 

    We still check for the `rental`/`allsorts-rental` crates. But now if
they are detected we just emit a fatal error, instead of emitting a
warning and providing alternative behaviour.

The original "hack" implementing alternative behaviour was added
in rust-lang#73345.

The lint was added in rust-lang#83127.

The tracking issue is rust-lang#83125.

The direct motivation for the change is that providing the alternative
behaviour is interfering with rust-lang#125174 and follow-on work.
    @nnethercote
    nnethercote committed May 27, 2024
    Configuration menu
    Copy the full SHA
    cf0c2c7 View commit details
    Browse the repository at this point in the history