Don't suggest turning non-char-literal exprs of ty char into string literals
#125640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
estebank
approved these changes
May 28, 2024
Comment on lines
+2067
to
+2070
| if let Ok(code) = self.tcx.sess().source_map().span_to_snippet(span) | ||
| && code.starts_with("'") | ||
| && code.ends_with("'") | ||
| { |
There was a problem hiding this comment.
It's unfortunate we don't have the (accurate) HIR nodes here :-/
|
@bors r=estebank rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 28, 2024
…kingjubilee Rollup of 5 pull requests Successful merges: - rust-lang#125089 (Improve diagnostic output the `non_local_definitions` lint) - rust-lang#125343 (`-Znext-solver`: eagerly normalize when adding goals) - rust-lang#125551 (Stabilise `IpvNAddr::{BITS, to_bits, from_bits}` (`ip_bits`)) - rust-lang#125640 (Don't suggest turning non-char-literal exprs of ty `char` into string literals) - rust-lang#125647 (update tracking issue for lazy_cell_consume) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 28, 2024
Rollup merge of rust-lang#125640 - fmease:plz-no-stringify, r=estebank Don't suggest turning non-char-literal exprs of ty `char` into string literals Fixes rust-lang#125595. Fixes rust-lang#125081. r? estebank (rust-lang#122217) or compiler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #125595.
Fixes #125081.
r? estebank (#122217) or compiler