MCDC Coverage: instrument last boolean RHS operands from condition coverage #125766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @fee1-dead rustbot has assigned @fee1-dead. Use |
rustbot
added
S-waiting-on-review
|
r? compiler |
nnethercote
reviewed
May 30, 2024
RenjiSann
force-pushed
the
fresh-mcdc-branch-on-bool
branch
from
80c1cbf to
10d6546
Compare
|
@rustbot label +A-code-coverage |
rustbot
added
the
A-code-coverage
RenjiSann
force-pushed
the
fresh-mcdc-branch-on-bool
branch
from
10d6546 to
cb22039
Compare
Zalathar
reviewed
Jun 4, 2024
Zalathar
reviewed
Jun 4, 2024
|
Other than some tiny nitpicks, the main changes seem reasonable. When the nits are addressed (fixed or justified), this should be good to go. |
RenjiSann
force-pushed
the
fresh-mcdc-branch-on-bool
branch
from
cb22039 to
b0a0496
Compare
|
All nitpicks are addressed. This is good to go :) |
4 tasks
|
Hi, @Zalathar |
Zalathar
reviewed
Jun 18, 2024
|
I'm happy with this, with or without addressing my tiny nitpick. r+ from me, but I don't actually have permissions to add this to the queue on my own. |
|
(Sorry for the delay!) |
|
r=me once the @bors delegate=RenjiSann |
|
✌️ @RenjiSann, you can now approve this pull request! If @nnethercote told you to " |
Condition coverage extends branch coverage to treat the specific case of last operands of boolean decisions not involved in control flow. This is ultimately made for MCDC to be exhaustive on all boolean expressions. This patch adds a call to `visit_branch_coverage_operation` to track the top-level operand of the said decisions, and changes `visit_coverage_standalone_condition` so MCDC branch registration is called when enabled on these _last RHS_ cases.
RenjiSann
force-pushed
the
fresh-mcdc-branch-on-bool
branch
from
b0a0496 to
e15adef
Compare
|
Done 👍 |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 19, 2024
Rollup of 6 pull requests Successful merges: - rust-lang#125447 (Allow constraining opaque types during subtyping in the trait system) - rust-lang#125766 (MCDC Coverage: instrument last boolean RHS operands from condition coverage) - rust-lang#125880 (Remove `src/tools/rust-demangler`) - rust-lang#126154 (StorageLive: refresh storage (instead of UB) when local is already live) - rust-lang#126572 (override user defined channel when using precompiled rustc) - rust-lang#126662 (Unconditionally warn on usage of `wasm32-wasi`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 19, 2024
Rollup merge of rust-lang#125766 - RenjiSann:fresh-mcdc-branch-on-bool, r=nnethercote MCDC Coverage: instrument last boolean RHS operands from condition coverage Fresh PR from rust-lang#124652 -- This PR ensures that the top-level boolean expressions that are not part of the control flow are correctly instrumented thanks to condition coverage. See discussion on rust-lang#124120. Depends on `@Zalathar` 's condition coverage implementation rust-lang#125756.
|
@bors retry r- |
bors
added
S-waiting-on-author
This was referenced Jul 2, 2024
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 9, 2024
…thar [Coverage][MCDC] Group mcdc tests and fix panic when generating mcdc code for inlined expressions. ### Changes 1. Group all mcdc tests to one directory. 2. Since mcdc instruments different mappings for boolean expressions with normal branch coverage as rust-lang#125766 introduces, it would be better also trace branch coverage results in mcdc tests. 3. So far rustc does not call `CoverageInfoBuilderMethods::init_coverage` for inlined functions. As a result, it could panic if it tries to instrument mcdc statements for inlined functions due to uninitialized cond bitmaps. We can reproduce this issue by current nightly rustc and [the test](https://github.com/rust-lang/rust/pull/127234/files#diff-c81af6bf4869aa42f5c7334e3e86344475de362f673f54ce439ec75fcb5ac3e5) with flag `--release`. This patch fixes it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fresh PR from #124652
--
This PR ensures that the top-level boolean expressions that are not part of the control flow are correctly instrumented thanks to condition coverage.
See discussion on #124120.
Depends on @Zalathar 's condition coverage implementation #125756.