Migrate run make cdylib #125773

GuillaumeGomez · 2024-05-30T14:32:40Z

Part of #121876.

r? @jieyouxu

rustbot · 2024-05-30T14:32:49Z

The run-make-support library was changed

cc @jieyouxu

Some changes occurred in run-make tests.

cc @jieyouxu

jieyouxu

Thanks! Looks good in general, just left some suggestions.

tests/run-make/cdylib/rmake.rs

jieyouxu · 2024-05-31T09:21:30Z

@rustbot author

GuillaumeGomez · 2024-05-31T09:24:08Z

@bors ready

jieyouxu

Thanks, just one problem

jieyouxu · 2024-05-31T11:45:50Z

tests/run-make/cdylib/rmake.rs

+//     - `foo()` which calls `bar::bar()`.
+//     - `bar()` which implements basic addition.
+
+// @ignore-cross-compile


Problem: this needs to be

Suggested change

// @ignore-cross-compile

//@ ignore-cross-compile

jieyouxu · 2024-05-31T11:46:39Z

r=me after fixing the directive :3

GuillaumeGomez · 2024-05-31T14:02:36Z

@bors r=jieyouxu rollup

bors · 2024-05-31T14:02:39Z

📌 Commit c0646f7 has been approved by jieyouxu

It is now in the queue for this repository.

…ylib, r=jieyouxu Migrate run make cdylib Part of rust-lang#121876. r? `@jieyouxu`

…link-to-rust-dylib, r=jieyouxu Migrate `run-make/c-link-to-rust-dylib` to `rmake.rs` Part of rust-lang#121876. First commit comes from rust-lang#125773. r? `@jieyouxu`

…ylib, r=jieyouxu Migrate run make cdylib Part of rust-lang#121876. r? `@jieyouxu`

…ylib, r=jieyouxu Migrate run make cdylib Part of rust-lang#121876. r? ``@jieyouxu``

GuillaumeGomez · 2024-06-01T08:13:05Z

Fixed formatting.

jhpratt · 2024-06-01T08:15:10Z

@bors r=jieyouxu

bors · 2024-06-01T08:15:12Z

📌 Commit 8742bf3 has been approved by jieyouxu

It is now in the queue for this repository.

…ylib, r=jieyouxu Migrate run make cdylib Part of rust-lang#121876. r? `@jieyouxu`

…link-to-rust-dylib, r=jieyouxu Migrate `run-make/c-link-to-rust-dylib` to `rmake.rs` Part of rust-lang#121876. First commit comes from rust-lang#125773. r? `@jieyouxu`

…llaumeGomez Rollup of 4 pull requests Successful merges: - rust-lang#124577 (Stabilize `custom_code_classes_in_docs` feature) - rust-lang#125683 (Rewrite `suspicious-library`, `resolve-rename` and `incr-prev-body-beyond-eof` `run-make` tests in `rmake.rs` format) - rust-lang#125773 (Migrate run make cdylib) - rust-lang#125808 (Migrate `run-make/c-link-to-rust-dylib` to `rmake.rs`) r? `@ghost` `@rustbot` modify labels: rollup

…ylib, r=jieyouxu Migrate run make cdylib Part of rust-lang#121876. r? ``@jieyouxu``

…link-to-rust-dylib, r=jieyouxu Migrate `run-make/c-link-to-rust-dylib` to `rmake.rs` Part of rust-lang#121876. First commit comes from rust-lang#125773. r? ``@jieyouxu``

Rollup of 4 pull requests Successful merges: - rust-lang#124294 (Unroll first iteration of checked_ilog loop) - rust-lang#125773 (Migrate run make cdylib) - rust-lang#125808 (Migrate `run-make/c-link-to-rust-dylib` to `rmake.rs`) - rust-lang#125822 (Refactor `--print=check-cfg` test) r? `@ghost` `@rustbot` modify labels: rollup

bors · 2024-06-02T02:11:38Z

⌛ Testing commit 8742bf3 with merge 06d99cd...

bors · 2024-06-02T04:17:37Z

☀️ Test successful - checks-actions
Approved by: jieyouxu
Pushing 06d99cd to master...

…nk-to-rust-dylib, r=jieyouxu Migrate `run-make/c-link-to-rust-dylib` to `rmake.rs` Part of rust-lang#121876. First commit comes from rust-lang#125773. r? `@jieyouxu`

rust-timer · 2024-06-02T05:33:05Z

Finished benchmarking commit (06d99cd): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.4%	[0.4%, 0.4%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.4%	[0.4%, 0.4%]	1

Max RSS (memory usage)

Results (primary -2.9%, secondary 2.7%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.7%	[2.7%, 2.7%]	1
Improvements ✅ (primary)	-2.9%	[-2.9%, -2.9%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-2.9%	[-2.9%, -2.9%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 669.701s -> 667.911s (-0.27%)
Artifact size: 318.89 MiB -> 318.88 MiB (-0.00%)

…link-to-rust-dylib, r=jieyouxu Migrate `run-make/c-link-to-rust-dylib` to `rmake.rs` Part of rust-lang#121876. First commit comes from rust-lang#125773. r? `@jieyouxu`

Rollup merge of rust-lang#125808 - GuillaumeGomez:migrate-run-make-c-link-to-rust-dylib, r=jieyouxu Migrate `run-make/c-link-to-rust-dylib` to `rmake.rs` Part of rust-lang#121876. First commit comes from rust-lang#125773. r? `@jieyouxu`

rustbot assigned jieyouxu May 30, 2024

rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels May 30, 2024

This comment has been minimized.

Sign in to view

GuillaumeGomez force-pushed the migrate-run-make-cdylib branch from 852aae4 to 307f25f Compare May 30, 2024 14:44

This comment has been minimized.

Sign in to view

GuillaumeGomez force-pushed the migrate-run-make-cdylib branch from 307f25f to 69936c7 Compare May 30, 2024 14:53

GuillaumeGomez mentioned this pull request May 31, 2024

Migrate run-make/c-link-to-rust-dylib to rmake.rs #125808

Merged

jieyouxu approved these changes May 31, 2024

View reviewed changes

tests/run-make/cdylib/rmake.rs Outdated Show resolved Hide resolved

tests/run-make/cdylib/rmake.rs Outdated Show resolved Hide resolved

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 31, 2024

GuillaumeGomez force-pushed the migrate-run-make-cdylib branch from 69936c7 to 1a65cc4 Compare May 31, 2024 09:24

jieyouxu requested changes May 31, 2024

View reviewed changes

GuillaumeGomez force-pushed the migrate-run-make-cdylib branch from 1a65cc4 to c0646f7 Compare May 31, 2024 11:59

jieyouxu approved these changes May 31, 2024

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 31, 2024

jieyouxu added a commit to jieyouxu/rust that referenced this pull request May 31, 2024

Rollup merge of rust-lang#125773 - GuillaumeGomez:migrate-run-make-cd…

e3042f7

…ylib, r=jieyouxu Migrate run make cdylib Part of rust-lang#121876. r? `@jieyouxu`

jieyouxu mentioned this pull request May 31, 2024

Rollup of 9 pull requests #125820

Closed

jhpratt added a commit to jhpratt/rust that referenced this pull request Jun 1, 2024

Rollup merge of rust-lang#125773 - GuillaumeGomez:migrate-run-make-cd…

babb8db

…ylib, r=jieyouxu Migrate run make cdylib Part of rust-lang#121876. r? `@jieyouxu`

jhpratt mentioned this pull request Jun 1, 2024

Rollup of 4 pull requests #125838

Closed

jhpratt added a commit to jhpratt/rust that referenced this pull request Jun 1, 2024

Rollup merge of rust-lang#125773 - GuillaumeGomez:migrate-run-make-cd…

35622d7

…ylib, r=jieyouxu Migrate run make cdylib Part of rust-lang#121876. r? ``@jieyouxu``

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 1, 2024

GuillaumeGomez added 2 commits June 1, 2024 10:12

Add Cc::output method

b0d0cc6

Migrate run-make/cdylib to rmake.rs

8742bf3

GuillaumeGomez force-pushed the migrate-run-make-cdylib branch from c0646f7 to 8742bf3 Compare June 1, 2024 08:13

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 1, 2024

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jun 1, 2024

Rollup merge of rust-lang#125773 - GuillaumeGomez:migrate-run-make-cd…

5cce92e

…ylib, r=jieyouxu Migrate run make cdylib Part of rust-lang#121876. r? `@jieyouxu`

GuillaumeGomez mentioned this pull request Jun 1, 2024

Rollup of 4 pull requests #125848

Closed

fmease added a commit to fmease/rust that referenced this pull request Jun 1, 2024

Rollup merge of rust-lang#125773 - GuillaumeGomez:migrate-run-make-cd…

2294577

…ylib, r=jieyouxu Migrate run make cdylib Part of rust-lang#121876. r? ``@jieyouxu``

fmease mentioned this pull request Jun 1, 2024

Rollup of 4 pull requests #125872

Closed

bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 2, 2024

bors merged commit 06d99cd into rust-lang:master Jun 2, 2024
7 checks passed

rustbot added this to the 1.80.0 milestone Jun 2, 2024

GuillaumeGomez deleted the migrate-run-make-cdylib branch June 2, 2024 08:20

jieyouxu mentioned this pull request Jun 9, 2024

Tracking Issue for porting run-make tests to use Rust #121876

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate run make cdylib #125773

Migrate run make cdylib #125773

GuillaumeGomez commented May 30, 2024

rustbot commented May 30, 2024

This comment has been minimized.

This comment has been minimized.

jieyouxu left a comment

jieyouxu commented May 31, 2024

GuillaumeGomez commented May 31, 2024

jieyouxu left a comment

jieyouxu May 31, 2024

jieyouxu May 31, 2024

jieyouxu commented May 31, 2024

GuillaumeGomez commented May 31, 2024

bors commented May 31, 2024

GuillaumeGomez commented Jun 1, 2024

jhpratt commented Jun 1, 2024

bors commented Jun 1, 2024

bors commented Jun 2, 2024

bors commented Jun 2, 2024

rust-timer commented Jun 2, 2024

Migrate run make cdylib #125773

Migrate run make cdylib #125773

Conversation

GuillaumeGomez commented May 30, 2024

rustbot commented May 30, 2024

This comment has been minimized.

This comment has been minimized.

jieyouxu left a comment

Choose a reason for hiding this comment

jieyouxu commented May 31, 2024

GuillaumeGomez commented May 31, 2024

jieyouxu left a comment

Choose a reason for hiding this comment

jieyouxu May 31, 2024

Choose a reason for hiding this comment

jieyouxu May 31, 2024

Choose a reason for hiding this comment

jieyouxu commented May 31, 2024

GuillaumeGomez commented May 31, 2024

bors commented May 31, 2024

GuillaumeGomez commented Jun 1, 2024

jhpratt commented Jun 1, 2024

bors commented Jun 1, 2024

bors commented Jun 2, 2024

bors commented Jun 2, 2024

rust-timer commented Jun 2, 2024

Overall result: ❌ regressions - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size