Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise DEFAULT_MIN_STACK_SIZE to at least 64KiB #126059

Merged
merged 1 commit into from
Jun 7, 2024

Commits on Jun 6, 2024

  1. Raise DEFAULT_MIN_STACK_SIZE to at least 64KiB

    Prevent copy-paste errors from producing new starved-for-resources
    threaded platforms by raising `DEFAULT_MIN_STACK_SIZE` from 4096 bytes
    to at least 64KiB.
    
    Two platforms "affected" by this have no actual threads:
    - UEFI
    - "unsupported"
    
    Platforms that this actually affects:
    - wasm32-wasi with "atomics" enabled
    - wasm32-wasi-p1-threads
    
    Two exceptions:
    - SGX: a "secure code execution" platform, stays at 4096B
    - TEEOS: also a "secure code execution" platform, stays at 8192B
    
    I believe either of these may have sufficiently "interesting" semantics
    around threads, or significant external library support. Either would
    mean making any choices here for them is suspect.
    workingjubilee committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    8781074 View commit details
    Browse the repository at this point in the history