Port tests/run-make-fulldeps/hotplug_codegen_backend to ui-fulldeps
#126111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-testsuite
|
Some changes occurred in src/tools/compiletest cc @jieyouxu |
Zalathar
force-pushed
the
fulldeps-hotplug
branch
from
1d5dd9b
to
af53d00
Compare
Zalathar
commented
Jun 7, 2024
jieyouxu
approved these changes
Jun 7, 2024
|
r=me after CI is green. @bors delegate+ rollup=iffy (this might be slightly wonky in full build CI) |
|
CI is green. @bors r=jieyouxu |
bors
added
S-waiting-on-bors
Zalathar
force-pushed
the
fulldeps-hotplug
branch
from
af53d00
to
7c9b469
Compare
|
OK, I've pushed a small update that lets us emit the “full” deps file instead of a bare-bones one (diff). |
|
(With the update, the change to detect |
jieyouxu
approved these changes
Jun 7, 2024
|
Looks good, r=me after CI is green as usual. |
|
CI is green. @bors r=jieyouxu |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jun 7, 2024
Improve docs for using custom paths with `--emit` Recently I found myself concluding that this feature didn't exist (rust-lang#126111 (comment)), despite having read the documentation, because it was hidden away in the middle of a paragraph full of other information. Giving this documentation more space of its own should make it easier to find.
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jun 7, 2024
Improve docs for using custom paths with `--emit` Recently I found myself concluding that this feature didn't exist (rust-lang#126111 (comment)), despite having read the documentation, because it was hidden away in the middle of a paragraph full of other information. Giving this documentation more space of its own should make it easier to find.
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jun 7, 2024
Improve docs for using custom paths with `--emit` Recently I found myself concluding that this feature didn't exist (rust-lang#126111 (comment)), despite having read the documentation, because it was hidden away in the middle of a paragraph full of other information. Giving this documentation more space of its own should make it easier to find.
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 7, 2024
Rollup merge of rust-lang#126119 - Zalathar:emit-filename, r=ehuss Improve docs for using custom paths with `--emit` Recently I found myself concluding that this feature didn't exist (rust-lang#126111 (comment)), despite having read the documentation, because it was hidden away in the middle of a paragraph full of other information. Giving this documentation more space of its own should make it easier to find.
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (d8fde50): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesResults (primary 1.7%, secondary 2.6%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: missing data |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jun 9, 2024
…-ozkan Remove empty test suite `tests/run-make-fulldeps` After rust-lang#109770, there were only a handful of tests left in the run-make-fulldeps suite. As of rust-lang#126111, there are no longer *any* run-make-fulldeps tests, so now we can: - Remove the directory - Remove related bootstrap/compiletest code - Remove various other references in CI scripts and documentation. By removing this suite, we also no longer need to worry about discrepancies between it and ui-fulldeps, and we don't have to worry about porting tests from Makefile to [rmake](rust-lang#121876) (or whether rmake even works with fulldeps).
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 9, 2024
Rollup merge of rust-lang#126155 - Zalathar:run-make-fulldeps, r=onur-ozkan Remove empty test suite `tests/run-make-fulldeps` After rust-lang#109770, there were only a handful of tests left in the run-make-fulldeps suite. As of rust-lang#126111, there are no longer *any* run-make-fulldeps tests, so now we can: - Remove the directory - Remove related bootstrap/compiletest code - Remove various other references in CI scripts and documentation. By removing this suite, we also no longer need to worry about discrepancies between it and ui-fulldeps, and we don't have to worry about porting tests from Makefile to [rmake](rust-lang#121876) (or whether rmake even works with fulldeps).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the last remaining run-make-fulldeps test, which means I actually had to leave behind a dummy README file to prevent compiletest from complaining about a missing directory.
(Removing the run-make-fulldeps suite entirely is non-trivial, so I intend to do so in a separate PR after this one.)
I wasn't sure about adding a new kind of aux build just for this one test, so I also tried to just port this test from Makefile to rmake instead.
But I found that I couldn't get rmake to fully work for a run-make-fulldeps test, which convinced me that getting rid of run-make-fulldeps is worthwhile.
r? @jieyouxu