rustdoc-search: use lowercase, non-normalized name for type search #126176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some changes occurred in HTML/CSS/JS. cc @GuillaumeGomez, @jsha |
rustbot
added
S-waiting-on-review
notriddle
force-pushed
the
notriddle/fix-type-name-normalize
branch
2 times, most recently
from
d16ddb6 to
ff0c10c
Compare
fmease
approved these changes
Jun 9, 2024
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 9, 2024
…rmalize, r=fmease rustdoc-search: use lowercase, non-normalized name for type search The type name ID map has underscores in its names, so the query element should have them, too. Fixes rust-lang#125993
This comment has been minimized.
This comment has been minimized.
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
Right, I guess we should make this a platform-agnostic test ^^'. Min: pub type pid_t = i32;
pub fn get_pid() -> pid_t { 0 }
pub fn set_pid(_: pid_t) {}@rustbot author |
rustbot
added
S-waiting-on-author
notriddle
force-pushed
the
notriddle/fix-type-name-normalize
branch
from
ff0c10c to
f2d707d
Compare
|
Yeah. 🤦 @bors r=fmease |
bors
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
jieyouxu
added a commit
to jieyouxu/rust
that referenced
this pull request
Jun 9, 2024
…normalize, r=fmease rustdoc-search: use lowercase, non-normalized name for type search The type name ID map has underscores in its names, so the query element should have them, too. Fixes rust-lang#125993
|
Unfortunately this needs to |
bors
added
S-waiting-on-author
The type name ID map has underscores in its names, so the query element should have them, too.
notriddle
force-pushed
the
notriddle/fix-type-name-normalize
branch
from
f2d707d to
8865b8c
Compare
|
@bors r=fmease |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 9, 2024
Rollup of 4 pull requests Successful merges: - rust-lang#126172 (Weekly `cargo update`) - rust-lang#126176 (rustdoc-search: use lowercase, non-normalized name for type search) - rust-lang#126190 (Autolabel run-make tests, remind to update tracking issue) - rust-lang#126194 (Migrate more things to `WinError`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 9, 2024
Rollup merge of rust-lang#126176 - notriddle:notriddle/fix-type-name-normalize, r=fmease rustdoc-search: use lowercase, non-normalized name for type search The type name ID map has underscores in its names, so the query element should have them, too. Fixes rust-lang#125993
Folyd
added a commit
to Folyd/rust
that referenced
this pull request
Jun 10, 2024
Folyd
added a commit
to Folyd/rust
that referenced
this pull request
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type name ID map has underscores in its names, so the query element should have them, too.
Fixes #125993