Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delegation: fix ICE on late diagnostics #126234

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

Bryanskiy
Copy link
Contributor

fixes #124342

@rustbot
Copy link
Collaborator

rustbot commented Jun 10, 2024

r? @nnethercote

rustbot has assigned @nnethercote.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 10, 2024
@Bryanskiy
Copy link
Contributor Author

cc @petrochenkov

@petrochenkov
Copy link
Contributor

r? @petrochenkov
@bors r+

@bors
Copy link
Contributor

bors commented Jun 10, 2024

📌 Commit b8e8a9d has been approved by petrochenkov

It is now in the queue for this repository.

@rustbot rustbot assigned petrochenkov and unassigned nnethercote Jun 10, 2024
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 10, 2024
@rust-log-analyzer

This comment has been minimized.

@Bryanskiy Bryanskiy force-pushed the delegation-no-entry-ice branch from b8e8a9d to 040791a Compare June 10, 2024 16:28
@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Jun 10, 2024

📌 Commit 040791a has been approved by petrochenkov

It is now in the queue for this repository.

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jun 11, 2024
… r=petrochenkov

Delegation: fix ICE on late diagnostics

fixes rust-lang#124342
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 11, 2024
…iaskrgr

Rollup of 3 pull requests

Successful merges:

 - rust-lang#125913 (Spruce up the diagnostics of some early lints)
 - rust-lang#126140 (Rename `std::fs::try_exists` to  `std::fs::exists` and stabilize fs_try_exists)
 - rust-lang#126234 (Delegation: fix ICE on late diagnostics)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 11, 2024
Rollup of 5 pull requests

Successful merges:

 - rust-lang#125913 (Spruce up the diagnostics of some early lints)
 - rust-lang#126234 (Delegation: fix ICE on late diagnostics)
 - rust-lang#126253 (Simplify assert matchers in `run-make-support`)
 - rust-lang#126257 (Rename `needs-matching-clang` to `needs-force-clang-based-tests`)
 - rust-lang#126259 (reachable computation: clarify comments around consts)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 76acf26 into rust-lang:master Jun 11, 2024
6 checks passed
@rustbot rustbot added this to the 1.81.0 milestone Jun 11, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jun 11, 2024
Rollup merge of rust-lang#126234 - Bryanskiy:delegation-no-entry-ice, r=petrochenkov

Delegation: fix ICE on late diagnostics

fixes rust-lang#124342
@petrochenkov petrochenkov added the F-fn_delegation `#![feature(fn_delegation)]` label Jun 24, 2024
@Bryanskiy Bryanskiy deleted the delegation-no-entry-ice branch July 7, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
F-fn_delegation `#![feature(fn_delegation)]` S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ICE: late diagnostics: no entry found for key
6 participants