Commits on Jun 12, 2024

1. Use tidy to sort crate attributes for all compiler crates. …

   We already do this for a number of crates, e.g. `rustc_middle`,
   `rustc_span`, `rustc_metadata`, `rustc_span`, `rustc_errors`.
   
   For the ones we don't, in many cases the attributes are a mess.
   - There is no consistency about order of attribute kinds (e.g.
     `allow`/`deny`/`feature`).
   - Within attribute kind groups (e.g. the `feature` attributes),
     sometimes the order is alphabetical, and sometimes there is no
     particular order.
   - Sometimes the attributes of a particular kind aren't even grouped
     all together, e.g. there might be a `feature`, then an `allow`, then
     another `feature`.
   
   This commit extends the existing sorting to all compiler crates,
   increasing consistency. If any new attribute line is added there is now
   only one place it can go -- no need for arbitrary decisions.
   
   Exceptions:
   - `rustc_log`, `rustc_next_trait_solver` and `rustc_type_ir_macros`,
     because they have no crate attributes.
   - `rustc_codegen_gcc`, because it's quasi-external to rustc (e.g. it's
     ignored in `rustfmt.toml`).

   

   nnethercote committed Jun 12, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for 75b164d
   • Browse repository at this point

   Copy the full SHA

   75b164d View commit details

   Browse the repository at this point in the history