-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ./x clippy ci
#126321
base: master
Are you sure you want to change the base?
Add ./x clippy ci
#126321
Conversation
r? @onur-ozkan rustbot has assigned @onur-ozkan. Use |
The job Click to see the possible cause of the failure (guessed by this bot)
|
☔ The latest upstream changes (presumably #128334) made this pull request unmergeable. Please resolve the merge conflicts. |
@pietroalbini |
The
mingw-check
job runs some Clippy lints with custom-D
and-A
flags, and that is annoying when trying to reproduce that behavior locally. The only way to reproduce what CI is doing today is to go look at the dockerfile for that job, and that is far from ideal.This came up when doing the stage0 bump to 1.80.0 (#126273), as during stage0 bumps we get the new Clippy lints for the release. We don't want to update the release process instructions every single time something changes in the CI configuration, but rather I'd like a single command I can put in the instructions to check for newly introduced Clippy lints.
This PR adds that: the new
./x clippy ci
does what we do today in our CI, and the PR switches themingw-check
job to run that command.