Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove failing GUI test to stop blocking CI until it is fixed #126445

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

GuillaumeGomez
Copy link
Member

Until #126436 is solved, let's unblock rust CI.

r? @lqd

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jun 13, 2024
@lqd
Copy link
Member

lqd commented Jun 13, 2024

@bors r+

cc @matthiaskrgr we can bump the prio to whatever’s needed to override the tree close prio, when the tools builder is green 🤞

@bors
Copy link
Contributor

bors commented Jun 13, 2024

📌 Commit 9e466d3 has been approved by lqd

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jun 13, 2024

🌲 The tree is currently closed for pull requests below priority 13. This pull request will be tested once the tree is reopened.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 13, 2024
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Jun 13, 2024
Remove failing GUI test to stop blocking CI until it is fixed

Until rust-lang#126436 is solved, let's unblock rust CI.

r? `@lqd`
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 13, 2024
…kingjubilee

Rollup of 8 pull requests

Successful merges:

 - rust-lang#121216 (Always emit `native-static-libs` note, even if it is empty)
 - rust-lang#123726 (Clarify `Command::new` behavior for programs with arguments)
 - rust-lang#125722 (Indicate in `non_local_defs` lint that the macro needs to change)
 - rust-lang#126088 ([1/2] clean-up / general improvements)
 - rust-lang#126390 (Fix wording in {checked_}next_power_of_two)
 - rust-lang#126392 (Small style improvement in `gvn.rs`)
 - rust-lang#126402 (Fix wrong `assert_unsafe_precondition` message for `core::ptr::copy`)
 - rust-lang#126445 (Remove failing GUI test to stop blocking CI until it is fixed)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 13, 2024
…kingjubilee

Rollup of 8 pull requests

Successful merges:

 - rust-lang#121216 (Always emit `native-static-libs` note, even if it is empty)
 - rust-lang#123726 (Clarify `Command::new` behavior for programs with arguments)
 - rust-lang#125722 (Indicate in `non_local_defs` lint that the macro needs to change)
 - rust-lang#126088 ([1/2] clean-up / general improvements)
 - rust-lang#126390 (Fix wording in {checked_}next_power_of_two)
 - rust-lang#126392 (Small style improvement in `gvn.rs`)
 - rust-lang#126402 (Fix wrong `assert_unsafe_precondition` message for `core::ptr::copy`)
 - rust-lang#126445 (Remove failing GUI test to stop blocking CI until it is fixed)

r? `@ghost`
`@rustbot` modify labels: rollup
@workingjubilee
Copy link
Member

@bors p=14

@bors
Copy link
Contributor

bors commented Jun 14, 2024

⌛ Testing commit 9e466d3 with merge 0ef0dd2...

@bors
Copy link
Contributor

bors commented Jun 14, 2024

☀️ Test successful - checks-actions
Approved by: lqd
Pushing 0ef0dd2 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 14, 2024
@bors bors merged commit 0ef0dd2 into rust-lang:master Jun 14, 2024
7 checks passed
@rustbot rustbot added this to the 1.81.0 milestone Jun 14, 2024
@fmease
Copy link
Member

fmease commented Jun 14, 2024

@bors treeclosed-

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (0ef0dd2): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.3% [0.3%, 0.3%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (secondary -5.5%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-5.5% [-5.5%, -5.5%] 1
All ❌✅ (primary) - - 0

Cycles

Results (primary -3.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-3.1% [-5.6%, -1.0%] 8
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -3.1% [-5.6%, -1.0%] 8

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 671.518s -> 671.505s (-0.00%)
Artifact size: 320.38 MiB -> 320.37 MiB (-0.00%)

@GuillaumeGomez GuillaumeGomez deleted the rm-help-page branch June 14, 2024 08:54
@cuviper
Copy link
Member

cuviper commented Jun 14, 2024

This also hit beta in #126453, so I'm going to unilaterally backport the removal.

@cuviper cuviper added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Jun 14, 2024
@cuviper cuviper modified the milestones: 1.81.0, 1.80.0 Jun 14, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 14, 2024
[beta] backports and stage0 bump

- Bump stage0 to 1.79.0
- Do not define opaque types when selecting impls rust-lang#126258
- Remove failing GUI test to stop blocking CI until it is fixed rust-lang#126445

r? cuviper
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 1, 2024
…iddle

Add back `help-page.goml` rustdoc GUI test

Since rust-lang#127010 was merged, let's see if we can revert rust-lang#126445...

r? `@notriddle`
RalfJung pushed a commit to RalfJung/miri that referenced this pull request Jul 2, 2024
Add back `help-page.goml` rustdoc GUI test

Since rust-lang/rust#127010 was merged, let's see if we can revert rust-lang/rust#126445...

r? `@notriddle`
lnicola pushed a commit to lnicola/rust-analyzer that referenced this pull request Jul 11, 2024
Add back `help-page.goml` rustdoc GUI test

Since rust-lang/rust#127010 was merged, let's see if we can revert rust-lang/rust#126445...

r? `@notriddle`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants