Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Ignore some phase(syntax) tests #12659

Closed
wants to merge 1 commit into from

Conversation

alexcrichton
Copy link
Member

These tests are failing on the snap builders, and are now tagged with a FIXME.

cc #12102

@alexcrichton
Copy link
Member Author

@alexcrichton
Copy link
Member Author

Perhaps things aren't getting cleaned, or perhaps this means that the SVH for i686 changed between stage{1,2}. I would rather get a new snap than block on investigation

@sfackler
Copy link
Member

sfackler commented Mar 2, 2014

The dependency tracking for fulldeps seems pretty broken to me, so I'm thinking it's probably just a cleaning issue.

@@ -10,6 +10,7 @@

// aux-build:macro_crate_test.rs
// ignore-stage1
// ignore-cross-compile #12102
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test shouldn't need this, since it'll stop at feature gating.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha, this was just failing locally due to some dependencies not getting built, reverted.

These tests are failing on the snap builders, and are now tagged with a FIXME.

cc rust-lang#12102
@alexcrichton
Copy link
Member Author

A description of what I believe is going on: #12102 (comment)

bors added a commit that referenced this pull request Mar 3, 2014
These tests are failing on the snap builders, and are now tagged with a FIXME.

cc #12102
@bors bors closed this Mar 3, 2014
@alexcrichton alexcrichton deleted the fix-snap branch March 3, 2014 04:21
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 25, 2022
fix: Fix flycheck sending cancel progress with no running process

Fixes rust-lang#12659
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants