-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 6 pull requests #126745
Rollup of 6 pull requests #126745
Conversation
the `tail-expr-lock-poisoning` UI test uses the `panic::catch_unwind` API so it relies on unwinding being implemented. this test ought not to run on targets that do not support unwinding. add the `needs-unwind` attribute to signal this
…youxu Migrate `link-args-order`, `ls-metadata` and `lto-readonly-lib` `run-make` tests to `rmake` Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). Guaranteed to fail CI until rust-lang#125736 gets merged. Will require addition of `fs_wrapper::set_permissions` in the associated module. try-job: x86_64-msvc
…mpressed-debuginfo, r=jieyouxu Migrate `run-make/compressed-debuginfo` to `rmake.rs` Part of rust-lang#121876. r? ````@jieyouxu````
Rewrite `extern-flag-rename-transitive`. `debugger-visualizer-dep-info`, `metadata-flag-frobs-symbols`, `extern-overrides-distribution` and `forced-unwind-terminate-pof` `run-make` tests to rmake Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). try-job: dist-x86_64-apple
collect attrs in const block expr Fixes rust-lang#126516 Fixes rust-lang#126647 It was forgotten to collect these attributes in the const block expression. r? `@petrochenkov`
…s, r=compiler-errors Remove `feature(const_closures)` from libcore This is an incomplete feature and apparently it has no uses in `core`. Incomplete features should generally not be used in our standard library.
… r=lcnr add `needs-unwind` to UI test the `tail-expr-lock-poisoning` UI test uses the `panic::catch_unwind` API so it relies on unwinding being implemented. this test ought not to run on targets that do not support unwinding. add the `needs-unwind` attribute to signal this
@bors r+ rollup=never p=6 |
☀️ Test successful - checks-actions |
📌 Perf builds for each rolled up PR:
previous master: cb8a7ea0ed In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
Finished benchmarking commit (4333551): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 691.131s -> 691.081s (-0.01%) |
Successful merges:
link-args-order
,ls-metadata
andlto-readonly-lib
run-make
tests tormake
#126095 (Migratelink-args-order
,ls-metadata
andlto-readonly-lib
run-make
tests tormake
)run-make/compressed-debuginfo
tormake.rs
#126629 (Migraterun-make/compressed-debuginfo
tormake.rs
)extern-flag-rename-transitive
.debugger-visualizer-dep-info
,metadata-flag-frobs-symbols
,extern-overrides-distribution
andforced-unwind-terminate-pof
run-make
tests to rmake #126644 (Rewriteextern-flag-rename-transitive
.debugger-visualizer-dep-info
,metadata-flag-frobs-symbols
,extern-overrides-distribution
andforced-unwind-terminate-pof
run-make
tests to rmake)feature(const_closures)
from libcore #126737 (Removefeature(const_closures)
from libcore)needs-unwind
to UI test #126740 (addneeds-unwind
to UI test)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup