Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E0191 suggestion correction, inserts turbofish #127094

Merged
merged 1 commit into from
Jul 10, 2024
Merged

E0191 suggestion correction, inserts turbofish #127094

merged 1 commit into from
Jul 10, 2024

Conversation

Borgerr
Copy link
Contributor

@Borgerr Borgerr commented Jun 28, 2024

closes #91997

@rustbot
Copy link
Collaborator

rustbot commented Jun 28, 2024

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 28, 2024
@rustbot
Copy link
Collaborator

rustbot commented Jun 28, 2024

HIR ty lowering was modified

cc @fmease

@compiler-errors compiler-errors assigned fmease and unassigned davidtwco Jun 28, 2024
@Borgerr Borgerr force-pushed the E0191-suggestion-correction branch from 5e4922f to f8911e3 Compare July 1, 2024 00:57
@Borgerr Borgerr closed this Jul 1, 2024
@Borgerr
Copy link
Contributor Author

Borgerr commented Jul 1, 2024

Closing until further notice from @fmease. I've added what I believe to be the expected results from the appropriate tests, as well as a new test taken from #91997.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@fmease fmease reopened this Jul 1, 2024
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 1, 2024
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Borgerr Borgerr force-pushed the E0191-suggestion-correction branch from e049e7c to e3b99a1 Compare July 7, 2024 04:21
@Borgerr
Copy link
Contributor Author

Borgerr commented Jul 7, 2024

@fmease Thank you for your patience 😅 this should fix the issues I was having previously. Looking forward to your feedback.

@Borgerr
Copy link
Contributor Author

Borgerr commented Jul 7, 2024

@rustbot label -S-waiting-on-author +S-waiting-on-review

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 7, 2024
fmease
fmease approved these changes Jul 9, 2024
View reviewed changes
Copy link
Member

@fmease fmease left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'll bors-approve after a squash into one commit

compiler/rustc_hir_analysis/src/hir_ty_lowering/errors.rs Show resolved Hide resolved
compiler/rustc_hir_analysis/src/hir_ty_lowering/errors.rs Show resolved Hide resolved
compiler/rustc_hir_analysis/src/hir_ty_lowering/errors.rs Show resolved Hide resolved
@fmease fmease added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 9, 2024
@Borgerr Borgerr force-pushed the E0191-suggestion-correction branch from e3b99a1 to 7c88bda Compare July 9, 2024 23:21
@Borgerr
Copy link
Contributor Author

Borgerr commented Jul 9, 2024

That should do it! Thank you for all your help, here's to future collaboration 🎉

@fmease
Copy link
Member

fmease commented Jul 10, 2024

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jul 10, 2024

📌 Commit 7c88bda has been approved by fmease

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 10, 2024
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 10, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 10, 2024
@bors
Auto merge of rust-lang#127580 - matthiaskrgr:rollup-pjw1xmj, r=matth…
c092b28 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#126476 (Fix running bootstrap tests with a local Rust toolchain as the stage0)
 - rust-lang#127094 (E0191 suggestion correction, inserts turbofish)
 - rust-lang#127554 ( do not run test where it cannot run)
 - rust-lang#127564 (Temporarily remove me from review rotation.)
 - rust-lang#127568 (instantiate higher ranked goals in candidate selection again)
 - rust-lang#127569 (Fix local download of Docker caches from CI)
 - rust-lang#127570 ( small normalization improvement)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit a7fe30d into rust-lang:master Jul 10, 2024
6 checks passed
@rustbot rustbot added this to the 1.81.0 milestone Jul 10, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jul 10, 2024
@rust-timer
Unrolled build for rust-lang#127094
9073d60 
Rollup merge of rust-lang#127094 - Borgerr:E0191-suggestion-correction, r=fmease

E0191 suggestion correction, inserts turbofish

closes rust-lang#91997
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmease fmease fmease approved these changes

Assignees

@fmease fmease

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.81.0
Development

Successfully merging this pull request may close these issues.

E0191: "help: specify the associated type" suggested where this would be wrong
6 participants
@Borgerr @rustbot @rust-log-analyzer @fmease @bors @davidtwco