Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to the NetBSD archive URL rather than the CDN #127232

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

tgross35
Copy link
Contributor

@tgross35 tgross35 commented Jul 2, 2024

The CDN has been down for a few hours. Switch to an alternative for the time being so we can unblock CI.

It appears that the CDN is quite a bit faster, so we will likely want to switch back when available.

Context: https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/dist-x86_64-netbsd.20is.20borked

try-job: dist-x86_64-netbsd

@rustbot
Copy link
Collaborator

rustbot commented Jul 2, 2024

r? @Kobzol

rustbot has assigned @Kobzol.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Jul 2, 2024
@@ -27,7 +27,10 @@ mkdir -p /x-tools/x86_64-unknown-netbsd/sysroot

# URL=https://ci-mirrors.rust-lang.org/rustc

SOURCE_URL=https://cdn.netbsd.org/pub/NetBSD/NetBSD-9.0/source/sets
# FIXME: the archive URL is being used temporarily while the CDN is down.
# Change back to the original URL once it is back up.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should not do that, we should instead mirror it ourselves and use that URL.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, I updated the fixme to say that

@tgross35 tgross35 force-pushed the netbsd-cdn-workaround branch from f6008aa to 5dc002d Compare July 2, 2024 06:18
@tgross35
Copy link
Contributor Author

tgross35 commented Jul 2, 2024

Just realized the archive URL uses http and doesn't seem to have https, we may not want this then :/

I'll give it another half hour to see if the CDN comes back. If not, I'll add a SHA sum check. Nothing to calculate the correct SHA from except what's currently available at the archive URL, unfortunately... Open to suggestions

@notriddle
Copy link
Contributor

Nothing to calculate the correct SHA from except what's currently available at the archive URL, unfortunately... Open to suggestions

https://cdn.netbsd.org/pub/NetBSD/security/hashes/NetBSD-9.0_hashes.asc seems to work

@tgross35 tgross35 force-pushed the netbsd-cdn-workaround branch from 5dc002d to 95b682c Compare July 2, 2024 07:23
@tgross35
Copy link
Contributor Author

tgross35 commented Jul 2, 2024

CDN is still down. I added a check against the sha from @notriddle's link.

Could somebody @bors try if this looks correct?

@Noratrieb
Copy link
Member

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 2, 2024
Change to the NetBSD archive URL rather than the CDN

The CDN has been down for a few hours. Switch to an alternative for the time being so we can unblock CI.

It appears that the CDN is quite a bit faster, so we will likely want to switch back when available.

Context: https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/dist-x86_64-netbsd.20is.20borked
@bors
Copy link
Contributor

bors commented Jul 2, 2024

⌛ Trying commit 95b682c with merge cf0c6be...

@tgross35
Copy link
Contributor Author

tgross35 commented Jul 2, 2024

Why no dist-x86_64-netbsd in the try, it's in the top post 🤔

@tgross35
Copy link
Contributor Author

tgross35 commented Jul 2, 2024

Does <!-- homu-ignore:start --> .. <!-- homu-ignore:end --> make bors ignore try-job directives too? (my try-job was wrapped in those). Thought that was just what gets stripped from the commit message. Removed those comments in case that's it (I guess @Nilstrieb could you retry the try?)

edit: looks like this shouldn't matter?

def get_custom_jobs(ctx: GitHubCtx) -> List[str]:
"""
Tries to parse names of specific CI jobs that should be executed in the form of
try-job: <job-name>
from the commit message of the passed GitHub context.
"""
if ctx.commit_message is None:
return []
regex = re.compile(r"^try-job: (.*)", re.MULTILINE)
jobs = []
for match in regex.finditer(ctx.commit_message):
jobs.append(match.group(1))
return jobs
. No clue what happened then

edit edit: unless it needs to be in the actual commit message?

@Kobzol
Copy link
Contributor

Kobzol commented Jul 2, 2024

I think that the problem is that the stuff inside the comments is indeed ignored by homu, and it then doesn't add it to the commit message. You can see that it is not here: 95b682c.

CI reads the commit message, which is generated from the PR description by homu, but here it was ignored.

@tgross35
Copy link
Contributor Author

tgross35 commented Jul 2, 2024

Oh that makes more sense, thanks. I removed the comments, mind restarting the try? (assuming this still seems necessary)

@DianQK
Copy link
Member

DianQK commented Jul 2, 2024

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 2, 2024
Change to the NetBSD archive URL rather than the CDN

The CDN has been down for a few hours. Switch to an alternative for the time being so we can unblock CI.

It appears that the CDN is quite a bit faster, so we will likely want to switch back when available.

Context: https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/dist-x86_64-netbsd.20is.20borked

try-job: dist-x86_64-netbsd
@bors
Copy link
Contributor

bors commented Jul 2, 2024

⌛ Trying commit 95b682c with merge 5ec9064...

@rust-log-analyzer

This comment has been minimized.

@bors
Copy link
Contributor

bors commented Jul 2, 2024

💔 Test failed - checks-actions

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 2, 2024
@tgross35 tgross35 force-pushed the netbsd-cdn-workaround branch from 95b682c to 4c51d7f Compare July 2, 2024 08:32
@tgross35
Copy link
Contributor Author

tgross35 commented Jul 2, 2024

Forgot to rename a function, could use another try please

@Noratrieb
Copy link
Member

try harder
@bors try

@bors
Copy link
Contributor

bors commented Jul 2, 2024

⌛ Trying commit 4c51d7f with merge c6be106...

@bors bors added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 2, 2024
@Kobzol
Copy link
Contributor

Kobzol commented Jul 2, 2024

These spurious failures are really starting to compound...

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 2, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 2, 2024
…bzol

Change to the NetBSD archive URL rather than the CDN

The CDN has been down for a few hours. Switch to an alternative for the time being so we can unblock CI.

It appears that the CDN is quite a bit faster, so we will likely want to switch back when available.

Context: https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/dist-x86_64-netbsd.20is.20borked

try-job: dist-x86_64-netbsd
@bors
Copy link
Contributor

bors commented Jul 2, 2024

⌛ Testing commit 42ac903 with merge 678c1bd...

@rust-log-analyzer
Copy link
Collaborator

The job x86_64-msvc-ext failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
[RUSTC-TIMING] miri test:false 65.058
[RUSTC-TIMING] miri test:false 3.061
    Finished `release` profile [optimized] target(s) in 0.41s
thread 'main' panicked at src/lib.rs:1668:17:
failed to copy `C:\a\rust\rust\build\x86_64-pc-windows-msvc\stage1-tools\x86_64-pc-windows-msvc\release\miri.exe` to `C:\a\rust\rust\build\x86_64-pc-windows-msvc\stage1-tools-bin\miri.exe`: The process cannot access the file because it is being used by another process. (os error 32)
##[endgroup]
Build completed unsuccessfully in 0:00:10
  local time: Tue, Jul  2, 2024  3:17:39 PM
  network time: Tue, 02 Jul 2024 15:17:40 GMT

@bors
Copy link
Contributor

bors commented Jul 2, 2024

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 2, 2024
@dtolnay
Copy link
Member

dtolnay commented Jul 2, 2024

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 2, 2024
@bors
Copy link
Contributor

bors commented Jul 2, 2024

⌛ Testing commit 42ac903 with merge bcf38b5...

@bors
Copy link
Contributor

bors commented Jul 2, 2024

☀️ Test successful - checks-actions
Approved by: Kobzol
Pushing bcf38b5 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 2, 2024
@bors bors merged commit bcf38b5 into rust-lang:master Jul 2, 2024
7 checks passed
@rustbot rustbot added this to the 1.81.0 milestone Jul 2, 2024
@tgross35 tgross35 deleted the netbsd-cdn-workaround branch July 2, 2024 17:43
@Urgau Urgau mentioned this pull request Jul 2, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (bcf38b5): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (secondary 4.7%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
4.7% [4.4%, 5.0%] 8
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 695.108s -> 696.686s (0.23%)
Artifact size: 327.55 MiB -> 327.51 MiB (-0.01%)

@cuviper
Copy link
Member

cuviper commented Jul 6, 2024

I'm unilaterally backporting this to unblock #127377.

@rustbot label +beta-accepted

@rustbot rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Jul 6, 2024
@cuviper cuviper modified the milestones: 1.81.0, 1.80.0 Jul 6, 2024
@cuviper cuviper mentioned this pull request Jul 6, 2024
@tgross35
Copy link
Contributor Author

tgross35 commented Jul 6, 2024

I'm surprised that it is still down.

@he32 (since you're listed as the NetBSD maintainer) any clue if anyone from NetBSD are aware of this? Summary: the CDN for 9.0 and 9.1 have been 404ing for a few days (e.g. https://cdn.netbsd.org/pub/NetBSD/NetBSD-9.0/source/sets/). Other versions correctly redirected to the archive URL for a while while the CDN was down, and now seem to be back up at the CDN (e.g. https://cdn.netbsd.org/pub/NetBSD/NetBSD-9.2/source/sets/) - but 9.0 and 9.1 CDN links are just dead.

This isn't currently a problem for Rust since we switched to the archive URL (this PR), but presumably we aren't the only ones to experience some fallout.

bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 6, 2024
[beta] backports

- Properly gate `safe` keyword in pre-expansion rust-lang#126757
- Switch back `non_local_definitions` lint to allow-by-default rust-lang#127015
- Stall computing instance for drop shim until it has no unsubstituted const params rust-lang#127068
- Update LLVM submodule rust-lang#127190
-  Change to the NetBSD archive URL rather than the CDN rust-lang#127232

r? cuviper
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 6, 2024
[beta] backports

- Properly gate `safe` keyword in pre-expansion rust-lang#126757
- Switch back `non_local_definitions` lint to allow-by-default rust-lang#127015
- Stall computing instance for drop shim until it has no unsubstituted const params rust-lang#127068
- Update LLVM submodule rust-lang#127190
-  Change to the NetBSD archive URL rather than the CDN rust-lang#127232

r? cuviper
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 6, 2024
[beta] backports

- Properly gate `safe` keyword in pre-expansion rust-lang#126757
- Switch back `non_local_definitions` lint to allow-by-default rust-lang#127015
- Stall computing instance for drop shim until it has no unsubstituted const params rust-lang#127068
- Update LLVM submodule rust-lang#127190
-  Change to the NetBSD archive URL rather than the CDN rust-lang#127232

r? cuviper
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc beta-accepted Accepted for backporting to the compiler in the beta channel. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.