Fix incorrect suggestion for extra argument with a type error

[chenyukang]

Fixes #126246

I tried to fix it in the find_errors of ArgMatrix, but seems it's hard to avoid breaking some other test cases.

The root cause is we eliminate the first argument even with a type error at here:

rust/compiler/rustc_hir_typeck/src/fn_ctxt/checks.rs

Line 664 in 6292b2a

return compatibility_diagonal[provided_idx].clone();

So the left argument is always treated as extra one.

But if there is already a type error, an error message will be generated firstly, which make this issue a trivial one.

[rustbot]

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[jieyouxu]

r? @estebank (since you're likely more familiar with this argument mismatch suggestion)

[estebank]

I see, you're only handling the "one additional argument that doesn't exist is passed in" case. That's certainly an improvement. I think that we might be able to expand the initial condition to handle multiple, but tbqh, it's fine. Handling the most common case is worth it.

@bors r+

[bors]

📌 Commit 9f32459 has been approved by estebank

It is now in the queue for this repository.