Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove memory leaks in doctests in core, alloc, and std #127446

Merged
merged 7 commits into from
Jul 14, 2024
Merged

Remove memory leaks in doctests in core, alloc, and std #127446

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
93e3c00
Remove non-focused memory leaks in `alloc` doctests for Miri.
zachs18 Jul 7, 2024
e0ed696
Mitigate focused memory leaks in `alloc` doctests for Miri.
zachs18 Jul 7, 2024
e4c064d
Remove non-focused memory leaks in `core` doctests for Miri.
zachs18 Jul 7, 2024
36258ed
Mitigate focused memory leaks in `core` doctests for Miri.
zachs18 Jul 7, 2024
a10c7a4
Remove non-focused memory leak in `std` doctest for Miri.
zachs18 Jul 7, 2024
d8717cf
Re-enable Miri leak checking in CI.
zachs18 Jul 7, 2024
51727ba
Update src/bootstrap/mk/Makefile.in
zachs18 Jul 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/bootstrap/mk/Makefile.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,9 +58,8 @@ check-aux:
library/core \
library/alloc \
--no-doc
# Some doctests have intentional memory leaks.
# Some use file system operations to demonstrate dealing with `Result`.
zachs18 marked this conversation as resolved.
Show resolved Hide resolved
$(Q)MIRIFLAGS="-Zmiri-ignore-leaks -Zmiri-disable-isolation" \
$(Q)MIRIFLAGS="-Zmiri-disable-isolation" \
$(BOOTSTRAP) miri --stage 2 \
library/core \
library/alloc \
Expand All @@ -70,7 +69,7 @@ check-aux:
$(BOOTSTRAP) miri --stage 2 library/std \
--no-doc -- \
--skip fs:: --skip net:: --skip process:: --skip sys::pal::
$(Q)MIRIFLAGS="-Zmiri-ignore-leaks -Zmiri-disable-isolation" \
$(Q)MIRIFLAGS="-Zmiri-disable-isolation" \
$(BOOTSTRAP) miri --stage 2 library/std \
--doc -- \
--skip fs:: --skip net:: --skip process:: --skip sys::pal::
Expand Down
Loading