-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate 9 more very similar FFI run-make
tests to rmake
#127663
Conversation
The run-make-support library was changed cc @jieyouxu This PR modifies cc @jieyouxu |
This comment has been minimized.
This comment has been minimized.
56e301d
to
55b9323
Compare
This comment has been minimized.
This comment has been minimized.
Question: should this be blocked on another PR that also introduces the build_native_lib helper? |
Yes, it should be.
Also, this CI failure is VERY weird. It doesn't seem related to what this PR changes. |
This comment has been minimized.
This comment has been minimized.
@rustbot author (pr was merged) |
☔ The latest upstream changes (presumably #127760) made this pull request unmergeable. Please resolve the merge conflicts. |
run-make
tests to rmakerun-make
tests to rmake
Just noticed it was failing because one of the files didn't get bundled with my commits. Please add |
@rustbot review |
Migrate 9 more very similar FFI `run-make` tests to rmake Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). For the tracking issue: - return-non-c-like-enum-from-c - pass-non-c-like-enum-to-c - c-static-dylib - c-static-rlib - extern-fn-generic - extern-fn-with-union - lto-no-link-whole-rlib - linkage-attr-on-static - issue-28595
Migrate 9 more very similar FFI `run-make` tests to rmake Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). For the tracking issue: - return-non-c-like-enum-from-c - pass-non-c-like-enum-to-c - c-static-dylib - c-static-rlib - extern-fn-generic - extern-fn-with-union - lto-no-link-whole-rlib - linkage-attr-on-static - issue-28595
☀️ Test successful - checks-actions |
pointer-auth-link-with-c
, c-dynamic-rlib
and c-dynamic-dylib
run-make
tests to rmake
#127872
Finished benchmarking commit (5069856): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (primary -2.5%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 771.36s -> 769.446s (-0.25%) |
Part of #121876 and the associated Google Summer of Code project.
For the tracking issue: