Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop using MoveDataParamEnv for places that don't need a param-env #128153

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Stop using MoveDataParamEnv for places that don't need a param-env #128153

merged 1 commit into from
Jul 30, 2024

Conversation

compiler-errors
Copy link
Member

I think not threading through a ParamEnv makes it clearer that these functions don't do anything particularly "type systems"-y.

r? cjgillot

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 24, 2024
@rustbot
Copy link
Collaborator

rustbot commented Jul 24, 2024

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

@bors
Copy link
Contributor

bors commented Jul 29, 2024

☔ The latest upstream changes (presumably #125443) made this pull request unmergeable. Please resolve the merge conflicts.

@cjgillot
Copy link
Contributor

R=me after rebase

@compiler-errors
Copy link
Member Author

@bors r=cjgillot rollup

@bors
Copy link
Contributor

bors commented Jul 29, 2024

📌 Commit f990239 has been approved by cjgillot

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 29, 2024
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 29, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 29, 2024
@bors
Auto merge of rust-lang#128360 - matthiaskrgr:rollup-wwy5mkj, r=matth…
368e2fd 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#126247 (rustdoc: word wrap CamelCase in the item list table and sidebar)
 - rust-lang#128104 (Not lint pub structs without pub constructors intentionally)
 - rust-lang#128153 (Stop using `MoveDataParamEnv` for places that don't need a param-env)
 - rust-lang#128284 (Stabilize offset_of_nested)
 - rust-lang#128342 (simplify the use of `CiEnv`)
 - rust-lang#128355 (triagebot: make sure Nora is called Nora)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit b02cf4c into rust-lang:master Jul 30, 2024
6 checks passed
@rustbot rustbot added this to the 1.82.0 milestone Jul 30, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jul 30, 2024
@rust-timer
Unrolled build for rust-lang#128153
2979c42 
Rollup merge of rust-lang#128153 - compiler-errors:mdpe, r=cjgillot

Stop using `MoveDataParamEnv` for places that don't need a param-env

I think not threading through a `ParamEnv` makes it clearer that these functions don't do anything particularly "type systems"-y.

r? cjgillot
@Kobzol
Copy link
Contributor

Kobzol commented Jul 30, 2024

@rust-timer build 2979c42

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (2979c42): comparison URL.

Overall result: ❌ regressions - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 1.6% [1.6%, 1.6%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary 4.5%, secondary 3.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 4.5% [4.5%, 4.5%] 1
Regressions ❌
(secondary)		 3.1% [3.1%, 3.1%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 4.5% [4.5%, 4.5%] 1

Cycles

Results (secondary 2.9%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 2.9% [2.9%, 2.9%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 769.793s -> 769.839s (0.01%)
Artifact size: 331.78 MiB -> 331.86 MiB (0.03%)

@compiler-errors compiler-errors deleted the mdpe branch July 31, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cjgillot cjgillot

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.82.0
Development

Successfully merging this pull request may close these issues.
6 participants
@compiler-errors @rustbot @bors @cjgillot @Kobzol @rust-timer