RFC: Add OsUnknown as a target operating system #12841
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First step in supporting bare-metal targets, allows for cfg annotations and ignores dylib crate-type annotations.
|
We have recently adopted a new RFC process, and this is a large enough change that I think that it warrants an RFC. You'll need to follow the process described in the email (there are a few example PRs already as well) before submitting changes to this repo. |
This was referenced Jun 17, 2014
fasterthanlime
pushed a commit
to fasterthanlime/rust
that referenced
this pull request
Jul 22, 2022
fix: Fix `trait_impls_in_deps_query` being called directly instead of as a query Fixes the inlay hint performance regression introdcuced by rust-lang/rust-analyzer#12549
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 30, 2024
fulfill expectations in `check_partial_eq_without_eq` This is a followup to rust-lang#12804, fixing a similar issue for `derive_partial_eq_without_eq` by using `span_lint_hir_and_then` instead of `span_lint_and_sugg`. Additionally tests for both `#[allow(clippy::derive_partial_eq_without_eq)]` and `#[expect(clippy::derive_partial_eq_without_eq)]` are added. changelog:[`derive_partial_eq_without_eq`]: fulfill expectations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First step in being able to build libstd against newlib (or other compatible c-library) for embedded targets. This enables a target triple to be specified of the form
*-unknown-*. Next step to getting libstd to build is adding weak linkages or#[cfg(target_os = "unknown")]. Newlib provides libc, libm and libstc++ (exceptions too) and can be ported to other platforms by implementing 17-18 basic functions to interact with the OS/hardware.This pull request just adds the unknown os target to librustc. The only additional change is that it ignores
#[crate-type = "dylib"]in crates (as unknown OS cannot support dynamic linking). If dylib is specified using the--crate-typeflag then an appropriate error is produced.Next steps would be getting libstd to build a rlib, getting a binary to link, and writing a test that makes sure libstd can be built.