-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Temporarily switch ambiguous_negative_literals
lint to allow
#128449
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Jul 31, 2024
@bors r+ rollup |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Jul 31, 2024
tgross35
added a commit
to tgross35/rust
that referenced
this pull request
Jul 31, 2024
… r=compiler-errors Temporarily switch `ambiguous_negative_literals` lint to allow This PR temporarily switch the `ambiguous_negative_literals` lint to `allow-by-default`, as asked by T-lang in rust-lang#128287 (comment).
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 31, 2024
Rollup of 8 pull requests Successful merges: - rust-lang#127567 (std: implement the `once_wait` feature) - rust-lang#127624 (Migrate and rename `issue-47551`, `issue-35164` and `issue-69368` `run-make` tests to rmake) - rust-lang#128162 (Cleanup sys module to match house style) - rust-lang#128437 (improve bootstrap to allow selecting llvm tools individually) - rust-lang#128443 (Properly mark loop as diverging if it has no breaks) - rust-lang#128449 (Temporarily switch `ambiguous_negative_literals` lint to allow) - rust-lang#128450 (Create COFF archives for non-LLVM backends) - rust-lang#128452 (derive(SmartPointer): require pointee to be maybe sized) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 1, 2024
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#127567 (std: implement the `once_wait` feature) - rust-lang#128162 (Cleanup sys module to match house style) - rust-lang#128296 (Update target-spec metadata for loongarch64 targets) - rust-lang#128443 (Properly mark loop as diverging if it has no breaks) - rust-lang#128449 (Temporarily switch `ambiguous_negative_literals` lint to allow) - rust-lang#128452 (derive(SmartPointer): require pointee to be maybe sized) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 1, 2024
Rollup merge of rust-lang#128449 - Urgau:tmp-allow-negative-lit-lint, r=compiler-errors Temporarily switch `ambiguous_negative_literals` lint to allow This PR temporarily switch the `ambiguous_negative_literals` lint to `allow-by-default`, as asked by T-lang in rust-lang#128287 (comment).
This was referenced Aug 1, 2024
BurntSushi
added a commit
to BurntSushi/jiff
that referenced
this pull request
Aug 15, 2024
In favor of a global one. But also, while these aren't technically needed any more[1,2], we leave them be for now while things settle. [1]: rust-lang/rust#128449 [2]: rust-lang/rust#128287
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR temporarily switch the
ambiguous_negative_literals
lint toallow-by-default
, as asked by T-lang in #128287 (comment).