Vec: remove the drop flag to make it no larger than (*T, uint, uint). #12845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| free(self.ptr as *mut c_void) | ||
| free(self.ptr as *mut c_void); | ||
|
|
||
| // Prevent further drop calls from having any effect. |
There was a problem hiding this comment.
would you mind adding a test for this scenario? I just want to make sure that if someone mucks with things and messes up the logic here that we'll have a prayer of catching it in our test suite.
There was a problem hiding this comment.
This is not how unsafe_no_drop_flag works. It will cause the destructor to be run multiple times on different addresses due to moves. It causes a move to zero the entire value, so the check needs to be at the start of the destructor.
|
@alexcrichton I hope I didn't interfere with the roll-up by force pushing. |
bors
added a commit
that referenced
this pull request
Mar 13, 2014
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jun 13, 2024
…archo Dedup nonminimal_bool_methods diags Relates to rust-lang#12379 Fix `nonminimal_bool` lint so that it doesn't check the same span multiple times. `NotSimplificationVisitor` was called for each expression from `NonminimalBoolVisitor` whereas `NotSimplificationVisitor` also recursively checked all expressions. --- changelog: [`nonminimal_bool`]: Fix duplicate diagnostics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.