Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump conflicting_repr_hints lint to be shown in dependencies #128727

Merged
merged 1 commit into from
Aug 21, 2024
Merged

bump conflicting_repr_hints lint to be shown in dependencies #128727

merged 1 commit into from
Aug 21, 2024

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Aug 6, 2024 •
edited
Loading

This has been a future compatibility lint for years, let's bump it up to be shown in dependencies (so that hopefully we can then make it a hard error fairly soon).

Cc #68585

@rustbot
Copy link
Collaborator

rustbot commented Aug 6, 2024

r? @lcnr

rustbot has assigned @lcnr.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 6, 2024
@lcnr
Copy link
Contributor

lcnr commented Aug 6, 2024

r=me on the change, I think this change needs a compiler fcp, doesn't it?

@compiler-errors
Copy link
Member

Either compiler or lang. Not certain where it falls on the spectrum, given it's linting against something that (afaict?) was a compiler mistake to ever accept IMO. I guess compiler is fine, though.

Also, could we make this FCP apply to both bumping this to a FCW-in-deps now and bumping this to a hard error later? I don't believe it needs two FCPs.

@RalfJung
Copy link
Member Author

RalfJung commented Aug 6, 2024

Not sure, #127655 had a t-types t-compiler FCP while #127656 had nothing.

@lcnr
Copy link
Contributor

lcnr commented Aug 8, 2024

cc @rust-lang/compiler on whether you think this needs an FCP. The actual change feels very much t-compiler to me

@lcnr
Copy link
Contributor

lcnr commented Aug 14, 2024 •
edited
Loading

intend to merge this PR in a few days without an FCP unless there's any pushback here. Started a zulip thread about the general procedure here https://rust-lang.zulipchat.com/#narrow/stream/131828-t-compiler/topic/FCP.20for.20bumping.20lints

@RalfJung feel free to ping me if I forget or just r+ it yourself then

@lcnr lcnr added S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 14, 2024
@wesleywiser
Copy link
Member

I think it's fine to start reporting this future compatibility lint without an FCP. I do think whenever we turn this into a hard error, we should do an FCP at that point.

@RalfJung
Copy link
Member Author

intend to merge this PR in a few days without an FCP unless there's any pushback here

"a few days" have passed and the only comment was approving, so let's land this.
@bors r=lcnr

@bors
Copy link
Contributor

bors commented Aug 21, 2024

📌 Commit ac23a2e has been approved by lcnr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). labels Aug 21, 2024
@matthiaskrgr matthiaskrgr mentioned this pull request Aug 21, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 21, 2024
@bors
Auto merge of rust-lang#129370 - matthiaskrgr:rollup-g9117ee, r=matth…
a32d4a0 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#128727 (bump conflicting_repr_hints lint to be shown in dependencies)
 - rust-lang#129232 (Fix `thread::sleep` Duration-handling for ESP-IDF)
 - rust-lang#129321 (Change neutral element of <fNN as iter::Sum> to neg_zero)
 - rust-lang#129353 (llvm-wrapper: adapt for LLVM 20 API changes)
 - rust-lang#129363 (Force `LC_ALL=C` for all run-make tests)
 - rust-lang#129364 (safe transmute: gracefully bubble-up layout errors)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 5a93c74 into rust-lang:master Aug 21, 2024
6 checks passed
@rustbot rustbot added this to the 1.82.0 milestone Aug 21, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Aug 21, 2024
@rust-timer
Unrolled build for rust-lang#128727
0db61a8 
Rollup merge of rust-lang#128727 - RalfJung:conflicting-repr-future-incompat, r=lcnr

bump conflicting_repr_hints lint to be shown in dependencies

This has been a future compatibility lint for years, let's bump it up to be shown in dependencies (so that hopefully we can then make it a hard error fairly soon).

Cc rust-lang#68585
@RalfJung RalfJung deleted the conflicting-repr-future-incompat branch August 22, 2024 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lcnr lcnr

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.82.0
Development

Successfully merging this pull request may close these issues.
6 participants
@RalfJung @rustbot @lcnr @compiler-errors @wesleywiser @bors