-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coalesce dep-info
, dep-info-spaces
and dep-info-doesnt-run-much
run-make
tests into dep-info
rmake.rs
#128787
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
// This is a simple smoke test for rustc's `--emit dep-info` feature. It prints out | ||
// information about dependencies in a Makefile-compatible format, as a `.d` file. | ||
// Note that this test does not check that the `.d` file is Makefile-compatible. | ||
|
||
// This test first checks that emitting dep-info disables static analysis, preventing | ||
// compilation of `erroneous.rs` from causing a compilation failure. | ||
// Then, it checks that compilation using the flag is successful in general, even with | ||
// empty source files or source files that contain a whitespace character. | ||
|
||
// Finally, it removes one dependency and checks that compilation is still successful. | ||
// See https://github.com/rust-lang/rust/pull/10698 | ||
|
||
use run_make_support::{rfs, rustc}; | ||
|
||
fn main() { | ||
// We're only emitting dep info, so we shouldn't be running static analysis to | ||
// figure out that this program is erroneous. | ||
rustc().input("erroneous.rs").emit("dep-info").run(); | ||
|
||
rustc().input("lib.rs").emit("dep-info,link").crate_type("lib").run(); | ||
rfs::remove_file("foo.rs"); | ||
rfs::create_file("foo.rs"); | ||
// Compilation should succeed even if `foo.rs` is empty. | ||
rustc().input("lib.rs").emit("dep-info,link").crate_type("lib").run(); | ||
|
||
// Again, with a space in the filename this time around. | ||
rustc().input("lib_foofoo.rs").emit("dep-info,link").crate_type("lib").run(); | ||
rfs::remove_file("foo foo.rs"); | ||
rfs::create_file("foo foo.rs"); | ||
// Compilation should succeed even if `foo foo.rs` is empty. | ||
rustc().input("lib_foofoo.rs").emit("dep-info,link").crate_type("lib").run(); | ||
|
||
// When a source file is deleted, compilation should still succeed if the library | ||
// also loses this source file dependency. | ||
rfs::remove_file("bar.rs"); | ||
rustc().input("lib2.rs").emit("dep-info,link").crate_type("lib").run(); | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: we should make it clear that we don't attempt to check the
.d
file is in fact Makefile-compatible in this test.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rustbot author