Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc: do not run doctests with invalid langstrings #128838

Merged
merged 2 commits into from
Aug 9, 2024
Merged

rustdoc: do not run doctests with invalid langstrings #128838

merged 2 commits into from
Aug 9, 2024

Conversation

notriddle
Copy link
Contributor

@rustbot
Copy link
Collaborator

rustbot commented Aug 8, 2024

r? @GuillaumeGomez

rustbot has assigned @GuillaumeGomez.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Aug 8, 2024
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@notriddle notriddle force-pushed the notriddle/invalid-tag-is-not-rust branch from 3e1f8aa to 7c4150f Compare August 8, 2024 20:33
@GuillaumeGomez
Copy link
Member

Thanks! Once merge, let's nominate it for beta so only one stable release will get this issue.

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 9, 2024

📌 Commit 1d19c2c has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 9, 2024
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Aug 9, 2024
@GuillaumeGomez
Rollup merge of rust-lang#128838 - notriddle:notriddle/invalid-tag-is…
a6a496b 
…-not-rust, r=GuillaumeGomez

rustdoc: do not run doctests with invalid langstrings

rust-lang#124577 (comment)

CC `@decathorpe`
@GuillaumeGomez GuillaumeGomez mentioned this pull request Aug 9, 2024
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Aug 9, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 9, 2024
@bors
Auto merge of rust-lang#128883 - matthiaskrgr:rollup-mkzi7my, r=matth…
19ebdce 
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#128815 (Add `Steal::is_stolen()`)
 - rust-lang#128817 (VxWorks code refactored )
 - rust-lang#128822 (add `builder-config` into tarball sources)
 - rust-lang#128838 (rustdoc: do not run doctests with invalid langstrings)
 - rust-lang#128852 (use stable sort to sort multipart diagnostics)
 - rust-lang#128859 (Fix the name of signal 19 in library/std/src/sys/pal/unix/process/process_unix/tests.rs for mips/sparc linux)
 - rust-lang#128864 (Use `SourceMap::end_point` instead of `- BytePos(1)` in arg removal suggestion)
 - rust-lang#128865 (Ensure let stmt compound assignment removal suggestion respect codepoint boundaries)
 - rust-lang#128874 (Disable verbose bootstrap command failure logging by default)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 9f11eb1 into rust-lang:master Aug 9, 2024
6 checks passed
@rustbot rustbot added this to the 1.82.0 milestone Aug 9, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 9, 2024
@bors
Auto merge of rust-lang#128881 - GuillaumeGomez:rollup-wlyb21s, r=Gui…
bb8dbea 
…llaumeGomez

Rollup of 8 pull requests

Successful merges:

 - rust-lang#128815 (Add `Steal::is_stolen()`)
 - rust-lang#128822 (add `builder-config` into tarball sources)
 - rust-lang#128838 (rustdoc: do not run doctests with invalid langstrings)
 - rust-lang#128852 (use stable sort to sort multipart diagnostics)
 - rust-lang#128859 (Fix the name of signal 19 in library/std/src/sys/pal/unix/process/process_unix/tests.rs for mips/sparc linux)
 - rust-lang#128864 (Use `SourceMap::end_point` instead of `- BytePos(1)` in arg removal suggestion)
 - rust-lang#128865 (Ensure let stmt compound assignment removal suggestion respect codepoint boundaries)
 - rust-lang#128874 (Disable verbose bootstrap command failure logging by default)

r? `@ghost`
`@rustbot` modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Aug 9, 2024
@rust-timer
Unrolled build for rust-lang#128838
4c98628 
Rollup merge of rust-lang#128838 - notriddle:notriddle/invalid-tag-is-not-rust, r=GuillaumeGomez

rustdoc: do not run doctests with invalid langstrings

rust-lang#124577 (comment)

CC ``@decathorpe``
@GuillaumeGomez GuillaumeGomez added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Aug 9, 2024
@GuillaumeGomez
Copy link
Member

I just beta-nominated it to have it fixed in the next release.

@notriddle notriddle deleted the notriddle/invalid-tag-is-not-rust branch August 9, 2024 20:24
@aDotInTheVoid aDotInTheVoid added the stable-nominated Nominated for backporting to the compiler in the stable channel. label Aug 10, 2024
@cuviper
Copy link
Member

cuviper commented Aug 29, 2024

Approved on Zulip:

@rustbot label +beta-accepted +stable-accepted

@rust-lang/rustdoc please don't forget such label changes! The release team usually only looks at the combined nominated+accepted labels for backport. (And I'll drop beta-nominated in a moment when I do the backport.)

Also, there's probably not going to be a stable 1.80.2 at this point, but we'll clear those labels after 1.81 beta promotion.

@rustbot rustbot added beta-accepted Accepted for backporting to the compiler in the beta channel. stable-accepted Accepted for backporting to the compiler in the stable channel. labels Aug 29, 2024
@cuviper cuviper mentioned this pull request Aug 29, 2024
Merged
@cuviper cuviper modified the milestones: 1.82.0, 1.81.0 Aug 29, 2024
@cuviper cuviper removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Aug 29, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 30, 2024
@bors
Auto merge of rust-lang#129758 - cuviper:beta-next, r=cuviper
d1ae3cc 
[beta] backports

- Emit specific message for `time<0.3.35` inference failure rust-lang#129343
- Use a reduced recursion limit in the MIR inliner's cycle breaker rust-lang#129714
- rustdoc: do not run doctests with invalid langstrings rust-lang#128838

r? cuviper
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 30, 2024
@bors
Auto merge of rust-lang#129758 - cuviper:beta-next, r=cuviper
1240644 
[beta] backports

- Emit specific message for `time<0.3.35` inference failure rust-lang#129343
- Use a reduced recursion limit in the MIR inliner's cycle breaker rust-lang#129714
- rustdoc: do not run doctests with invalid langstrings rust-lang#128838

r? cuviper
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 30, 2024
@bors
Auto merge of rust-lang#129758 - cuviper:beta-next, r=cuviper
0cec546 
[beta] backports

- Emit specific message for `time<0.3.35` inference failure rust-lang#129343
- Use a reduced recursion limit in the MIR inliner's cycle breaker rust-lang#129714
- rustdoc: do not run doctests with invalid langstrings rust-lang#128838

r? cuviper
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 30, 2024
@bors
Auto merge of rust-lang#129758 - cuviper:beta-next, r=cuviper
7a1aed2 
[beta] backports

- Emit specific message for `time<0.3.35` inference failure rust-lang#129343
- Use a reduced recursion limit in the MIR inliner's cycle breaker rust-lang#129714
- rustdoc: do not run doctests with invalid langstrings rust-lang#128838

r? cuviper
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 31, 2024
@bors
Auto merge of rust-lang#129758 - cuviper:beta-next, r=workingjubilee
170c7f8 
[beta] backports

- Emit specific message for `time<0.3.35` inference failure rust-lang#129343
- Use a reduced recursion limit in the MIR inliner's cycle breaker rust-lang#129714
- rustdoc: do not run doctests with invalid langstrings rust-lang#128838

r? cuviper
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 31, 2024
@bors
Auto merge of rust-lang#129758 - cuviper:beta-next, r=workingjubilee
a5503d4 
[beta] backports

- Emit specific message for `time<0.3.35` inference failure rust-lang#129343
- Use a reduced recursion limit in the MIR inliner's cycle breaker rust-lang#129714
- rustdoc: do not run doctests with invalid langstrings rust-lang#128838

r? cuviper
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 31, 2024
@bors
Auto merge of rust-lang#129758 - cuviper:beta-next, r=cuviper
4a101b4 
[beta] backports

- Emit specific message for `time<0.3.35` inference failure rust-lang#129343
- Use a reduced recursion limit in the MIR inliner's cycle breaker rust-lang#129714
- rustdoc: do not run doctests with invalid langstrings rust-lang#128838

r? cuviper
@cuviper cuviper removed stable-nominated Nominated for backporting to the compiler in the stable channel. stable-accepted Accepted for backporting to the compiler in the stable channel. labels Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees

@GuillaumeGomez GuillaumeGomez

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.81.0
Development

Successfully merging this pull request may close these issues.
7 participants
@notriddle @rustbot @rust-log-analyzer @GuillaumeGomez @bors @cuviper @aDotInTheVoid