Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify AST Visitors with a macro like MIR Visitors #128974

Draft
wants to merge 82 commits into
base: master
Choose a base branch
from
Draft

Unify AST Visitors with a macro like MIR Visitors #128974

wants to merge 82 commits into from
+2,394 −3,116

Commits on Oct 15, 2024

  1. Merge visit and mut_visit in a single file

    @maxcabrajac
    maxcabrajac committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    85e6071 View commit details
    Browse the repository at this point in the history

  2. Pull uses out of modules

    @maxcabrajac
    maxcabrajac committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    ad4a2f3 View commit details
    Browse the repository at this point in the history

  3. Add macro_if!

    @maxcabrajac
    maxcabrajac committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    ce290fa View commit details
    Browse the repository at this point in the history

  4. Add make_ast_visitor!

    @maxcabrajac
    maxcabrajac committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    eaaee58 View commit details
    Browse the repository at this point in the history

  5. Add ref_t!, result!, make_visit! and P!

    @maxcabrajac
    maxcabrajac committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    d8c70a2 View commit details
    Browse the repository at this point in the history

  6. Use make_visit! on every possible visit_

    @maxcabrajac
    maxcabrajac committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    4882464 View commit details
    Browse the repository at this point in the history

  7. Unify make_visit!s

    @maxcabrajac
    maxcabrajac committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    c7398d1 View commit details
    Browse the repository at this point in the history

  8. Add visits for nodes that already had walks (QSelf,FnRetTy,FnDecl)

    @maxcabrajac
    maxcabrajac committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    87cc131 View commit details
    Browse the repository at this point in the history

  9. Add return_result!, defer_P!, visit_{id,span}!, try_v! and visit_{o,l… 

    …ist}!
    @maxcabrajac
    maxcabrajac committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    c73930b View commit details
    Browse the repository at this point in the history

  10. Pass Ident by reference

    @maxcabrajac
    maxcabrajac committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    632dc06 View commit details
    Browse the repository at this point in the history

  11. Unify {visit,walk}_ident

    @maxcabrajac
    maxcabrajac committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    72457f5 View commit details
    Browse the repository at this point in the history

  12. Unify walk_label

    @maxcabrajac
    maxcabrajac committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    6d12aeb View commit details
    Browse the repository at this point in the history

  13. Unify {visit,walk}_lifetime

    @maxcabrajac
    maxcabrajac committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    736f784 View commit details
    Browse the repository at this point in the history

  14. Unify {visit,walk}_angle_bracketed_parameter_data

    @maxcabrajac
    maxcabrajac committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    3436219 View commit details
    Browse the repository at this point in the history

  15. Unify {visit,walk}_parenthesized_parameter_data

    @maxcabrajac
    maxcabrajac committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    80ac89f View commit details
    Browse the repository at this point in the history

  16. Unify walk_generic_args

    @maxcabrajac
    maxcabrajac committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    73f3285 View commit details
    Browse the repository at this point in the history

  17. Unify walk_fn_ret_ty

    @maxcabrajac
    maxcabrajac committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    b7df6f1 View commit details
    Browse the repository at this point in the history

  18. Unify walk_anon_const

    @maxcabrajac
    maxcabrajac committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    5238327 View commit details
    Browse the repository at this point in the history

  19. Unify walk_format_args

    @maxcabrajac
    maxcabrajac committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    26043fb View commit details
    Browse the repository at this point in the history

  20. Unify {visit,walk}_mt

    @maxcabrajac
    maxcabrajac committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    2458e61 View commit details
    Browse the repository at this point in the history

  21. Unify walk_closure_binder

    @maxcabrajac
    maxcabrajac committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    dfdd0b2 View commit details
    Browse the repository at this point in the history

  22. Unify walk_fn_decl

    @maxcabrajac
    maxcabrajac committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    59607ec View commit details
    Browse the repository at this point in the history

  23. Unify walk_poly_trait_ref

    @maxcabrajac
    maxcabrajac committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    f4504b6 View commit details
    Browse the repository at this point in the history

  24. Unify {visit,walk}_where_clause

    @maxcabrajac
    maxcabrajac committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    aecb5e3 View commit details
    Browse the repository at this point in the history

  25. Unify walk_generics

    @maxcabrajac
    maxcabrajac committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    13b296a View commit details
    Browse the repository at this point in the history

  26. Unify {visit,walk}_capture_by

    @maxcabrajac
    maxcabrajac committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    e49f850 View commit details
    Browse the repository at this point in the history

  27. Unify {visit,walk}_enum_def

    @maxcabrajac
    maxcabrajac committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    2d9bbfe View commit details
    Browse the repository at this point in the history

  28. Unify {visit,walk}_pat_field

    @maxcabrajac
    maxcabrajac committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    a90eac5 View commit details
    Browse the repository at this point in the history

  29. Unify {visit,walk}_param

    @maxcabrajac
    maxcabrajac committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    71c7203 View commit details
    Browse the repository at this point in the history

  30. Unify walk_where_predicate

    @maxcabrajac
    maxcabrajac committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    f90cad5 View commit details
    Browse the repository at this point in the history

  31. Unify {visit,walk}_variant_data (renaming walk_struct_def)

    @maxcabrajac
    maxcabrajac committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    87ca293 View commit details
    Browse the repository at this point in the history

  32. Unify {visit,walk}_expr_field

    @maxcabrajac
    maxcabrajac committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    74e242c View commit details
    Browse the repository at this point in the history

  33. Unify {visit,walk}_arm

    @maxcabrajac
    maxcabrajac committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    82468f6 View commit details
    Browse the repository at this point in the history

  34. Unify visit_variant_discr

    @maxcabrajac
    maxcabrajac committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    c956db5 View commit details
    Browse the repository at this point in the history

  35. Unify {visit,walk}_variant

    @maxcabrajac
    maxcabrajac committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    f0957be View commit details
    Browse the repository at this point in the history

  36. Unify walk_path_segment

    @maxcabrajac
    maxcabrajac committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    3398a69 View commit details
    Browse the repository at this point in the history

  37. Unify walk_qself

    @maxcabrajac
    maxcabrajac committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    23ba653 View commit details
    Browse the repository at this point in the history

  38. Unify {visit,walk}_field_def

    @maxcabrajac
    maxcabrajac committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    5e40db2 View commit details
    Browse the repository at this point in the history

  39. Unify walk_inline_asm

    @maxcabrajac
    maxcabrajac committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    d1529f9 View commit details
    Browse the repository at this point in the history

  40. Add mut_only_visit!

    @maxcabrajac
    maxcabrajac committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    bf12d09 View commit details
    Browse the repository at this point in the history

  41. Unify walk_local

    @maxcabrajac
    maxcabrajac committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    cbb9087 View commit details
    Browse the repository at this point in the history

  42. Unify {visit,walk}_use_tree

    @maxcabrajac
    maxcabrajac committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    5cac236 View commit details
    Browse the repository at this point in the history

  43. Unify {visit,walk}_path

    @maxcabrajac
    maxcabrajac committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    0de2305 View commit details
    Browse the repository at this point in the history

  44. Unify walk_generic_argz

    @maxcabrajac
    maxcabrajac committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    978fa3f View commit details
    Browse the repository at this point in the history

  45. Unify walk_param_bound

    @maxcabrajac
    maxcabrajac committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    a4abc86 View commit details
    Browse the repository at this point in the history

  46. Unify {visit,walk}_precise_capturing_arg

    @maxcabrajac
    maxcabrajac committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    ac3e06e View commit details
    Browse the repository at this point in the history

  47. Unify walk_trait_ref

    @maxcabrajac
    maxcabrajac committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    eba661f View commit details
    Browse the repository at this point in the history

  48. Unify {visit,walk}_block

    @maxcabrajac
    maxcabrajac committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    3863002 View commit details
    Browse the repository at this point in the history

  49. Unify walk_pat

    @maxcabrajac
    maxcabrajac committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    097269d View commit details
    Browse the repository at this point in the history

  50. Unify walk_inline_asm_sym

    @maxcabrajac
    maxcabrajac committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    479cc1c View commit details
    Browse the repository at this point in the history

  51. Unify walk_vis

    @maxcabrajac
    maxcabrajac committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    1b036e8 View commit details
    Browse the repository at this point in the history

  52. Unify {visit,walk}_generic_param

    @maxcabrajac
    maxcabrajac committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    d64f965 View commit details
    Browse the repository at this point in the history

  53. Unify walk_crate

    @maxcabrajac
    maxcabrajac committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    5887760 View commit details
    Browse the repository at this point in the history

  54. Add visit_attr_args and Unify walk_attr_args

    @maxcabrajac
    maxcabrajac committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    ad94bfd View commit details
    Browse the repository at this point in the history

  55. Add {visit,walk}_safety

    @maxcabrajac
    maxcabrajac committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    5002c21 View commit details
    Browse the repository at this point in the history

  56. Unify walk_ty

    @maxcabrajac
    maxcabrajac committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    ba05c88 View commit details
    Browse the repository at this point in the history

  57. Unify walk_assoc_item_constraint

    @maxcabrajac
    maxcabrajac committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    b7078cf View commit details
    Browse the repository at this point in the history

  58. Unify walk_mac_call

    @maxcabrajac
    maxcabrajac committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    364dc87 View commit details
    Browse the repository at this point in the history

  59. Unify walk_attribute

    @maxcabrajac
    maxcabrajac committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    0fa7e60 View commit details
    Browse the repository at this point in the history

  60. Unify {visit,walk}_foreign_mod

    @maxcabrajac
    maxcabrajac committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    f4e0a22 View commit details
    Browse the repository at this point in the history

  61. Unify {visit,walk}_macro_def

    @maxcabrajac
    maxcabrajac committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    ac7bb60 View commit details
    Browse the repository at this point in the history

  62. Unify {visit,walk}_ty_alias_where_clauses

    @maxcabrajac
    maxcabrajac committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    089d0ee View commit details
    Browse the repository at this point in the history

  63. Unify WalkItemKind and unimpl it for AssocItemKind

    @maxcabrajac
    maxcabrajac committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    fcb93eb View commit details
    Browse the repository at this point in the history

  64. Unify {visit,walk}{,_foreign}_item

    @maxcabrajac
    maxcabrajac committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    f42dcf1 View commit details
    Browse the repository at this point in the history

  65. Unify FnKind

    @maxcabrajac
    maxcabrajac committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    0595ae1 View commit details
    Browse the repository at this point in the history

  66. Unify {visit,walk}_coroutine_kind

    @maxcabrajac
    maxcabrajac committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    fd615f6 View commit details
    Browse the repository at this point in the history

  67. Unify {visit,walk}_fn

    @maxcabrajac
    maxcabrajac committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    9dbcb65 View commit details
    Browse the repository at this point in the history

  68. Add {visit,walk}_constness

    @maxcabrajac
    maxcabrajac committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    0bae806 View commit details
    Browse the repository at this point in the history

  69. Unify {visit,walk}_fn_header

    @maxcabrajac
    maxcabrajac committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    04239d4 View commit details
    Browse the repository at this point in the history

  70. Add {visit,walk}_impl_polarity

    @maxcabrajac
    maxcabrajac committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    2618c86 View commit details
    Browse the repository at this point in the history

  71. Add {visit,walk}_defaultness

    @maxcabrajac
    maxcabrajac committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    a8392b1 View commit details
    Browse the repository at this point in the history

  72. Unify impl WalkItemKind for ItemKind

    @maxcabrajac
    maxcabrajac committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    201db75 View commit details
    Browse the repository at this point in the history

  73. Unify impl WalkItemKind for ForeignItemKind

    @maxcabrajac
    maxcabrajac committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    b31b31b View commit details
    Browse the repository at this point in the history

  74. Unify {visit,walk}_assoc_item

    @maxcabrajac
    maxcabrajac committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    0e75ea0 View commit details
    Browse the repository at this point in the history

  75. Remove visit_expr_post

    @maxcabrajac
    maxcabrajac committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    d6a89c1 View commit details
    Browse the repository at this point in the history

  76. Unify walk_expr

    @maxcabrajac
    maxcabrajac committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    f097c35 View commit details
    Browse the repository at this point in the history

  77. Add flat maps to make_visit!

    @maxcabrajac
    maxcabrajac committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    a6d7ecc View commit details
    Browse the repository at this point in the history

  78. Use make_visit! to write flat maps

    @maxcabrajac
    maxcabrajac committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    6b814ca View commit details
    Browse the repository at this point in the history

  79. Add make_walk_flat_map

    @maxcabrajac
    maxcabrajac committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    24465fd View commit details
    Browse the repository at this point in the history

  80. Unify visit_method_receiver_expr

    @maxcabrajac
    maxcabrajac committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    6440429 View commit details
    Browse the repository at this point in the history

  81. Unify comment

    @maxcabrajac
    maxcabrajac committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    fdc62e4 View commit details
    Browse the repository at this point in the history

  82. Add FIXME asking for removal of some P!s

    @maxcabrajac
    maxcabrajac committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    87e6380 View commit details
    Browse the repository at this point in the history