safe transmute: check lifetimes #129217
Merged
safe transmute: check lifetimes #129217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @fee1-dead rustbot has assigned @fee1-dead. Use |
rustbot
added
S-waiting-on-review
jswrenn
force-pushed
the
transmute-lifetimes
branch
from
dc9c673
to
ec61df0
Compare
This comment has been minimized.
This comment has been minimized.
jswrenn
force-pushed
the
transmute-lifetimes
branch
from
ec61df0
to
330a66e
Compare
This comment has been minimized.
This comment has been minimized.
jswrenn
force-pushed
the
transmute-lifetimes
branch
from
330a66e
to
e33ec91
Compare
This comment has been minimized.
This comment has been minimized.
jswrenn
force-pushed
the
transmute-lifetimes
branch
from
e33ec91
to
68c087c
Compare
This comment has been minimized.
This comment has been minimized.
Modifies `BikeshedIntrinsicFrom` to forbid lifetime extensions on references. This static check can be opted out of with the `Assume::lifetimes` flag. Fixes rust-lang#129097
jswrenn
force-pushed
the
transmute-lifetimes
branch
from
68c087c
to
17995d5
Compare
| #[instrument(level = "debug", skip(tcx, obligation, predicate))] | ||
| use rustc_transmute::{Answer, Assume, Condition}; | ||
|
|
||
| /// Generate sub-obligations for reference-to-reference transmutations. |
There was a problem hiding this comment.
You should document or link to documentation for some sort of specification that explains when two references are safely transmutable.
There was a problem hiding this comment.
Or else, it would be nice to pull up these inline comments into some sort of bulleted list here.
compiler-errors
approved these changes
Aug 19, 2024
|
LGTM otherwise |
|
But I guess I also don't care to block this further @bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 19, 2024
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#129194 (Fix bootstrap test `detect_src_and_out` on Windows) - rust-lang#129217 (safe transmute: check lifetimes) - rust-lang#129223 ( Fix wrong argument for `get_fn_decl`) - rust-lang#129235 (Check that `#[may_dangle]` is properly applied) - rust-lang#129245 (Fix a typo in `rustc_hir` doc comment) - rust-lang#129271 (Prevent double panic in query system, improve diagnostics) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 19, 2024
Rollup merge of rust-lang#129217 - jswrenn:transmute-lifetimes, r=compiler-errors safe transmute: check lifetimes Modifies `BikeshedIntrinsicFrom` to forbid lifetime extensions on references. This static check can be opted out of with the `Assume::lifetimes` flag. Fixes rust-lang#129097 Tracking Issue: rust-lang#99571 r? `@compiler-errors`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifies
BikeshedIntrinsicFromto forbid lifetime extensions on references. This static check can be opted out of with theAssume::lifetimesflag.Fixes #129097
Tracking Issue: #99571
r? @compiler-errors