Rollup of 5 pull requests #129225
Rollup of 5 pull requests #129225
Conversation
This is a trivial Python script that simply tries to parse each line of stdin (i.e. the test process output) as JSON, to verify that the overall output is JSON Lines. We can perform the same check directly in `rmake.rs` using `serde_json`.
Use `ar_archive_writer` for writing COFF import libs on all backends This is mostly the same as the llvm backend but with the cranelift version copy/pasted in place of the LLVM library. try-job: x86_64-msvc try-job: i686-msvc try-job: i686-mingw try-job: aarch64-gnu try-job: aarch64-apple try-job: test-various try-job: armhf-gnu
…=compiler-errors Fix `is_val_statically_known` for floats The LLVM intrinsic name for floats differs from the LLVM type name, so handle them explicitly. Also adds support for `f16` and `f128`. `f16`/`f128` tracking issue: rust-lang#116909
Port `run-make/libtest-json/validate_json.py` to Rust This is a trivial Python script that simply tries to parse each line of stdin (i.e. the test process output) as JSON, to verify that the overall output is JSON Lines. We can perform the same check directly in `rmake.rs` using `serde_json`. r? ````@jieyouxu````
… r=jieyouxu Use cnum for extern crate data key Noticed this when fixing rust-lang#129184. I still have yet to put up a fix for that (mostly because I'm too lazy to minimize a test, that will come soon though).
Remove JohnTitor from review rotation This removes `@JohnTitor` from the review rotation. I haven't seen any comments from them in this repository since February, and PRs that get assigned to them tend to sit a few weeks until someone notices. I see that they are still semi-active with libc, but I haven't been able to reach them on Zulip. If `@JohnTitor` wants to get back on the rotation in the future, they are welcome (I don't want to pressure them, their support in the past was much appreciated).
rustbot
added
A-meta
|
@bors r+ rollup=never p=5 |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR:
previous master: 79f5c1605e In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
|
Finished benchmarking commit (7521bda): comparison URL. Overall result: ❌ regressions - ACTION NEEDEDNext Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)Results (secondary 0.6%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (primary 3.5%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 750.626s -> 751.941s (0.18%) |
|
I think that this is small enough (and mostly on @rustbot label: +perf-regression-triaged |
rustbot
added
the
perf-regression-triaged
Successful merges:
ar_archive_writerfor writing COFF import libs on all backends #129164 (Usear_archive_writerfor writing COFF import libs on all backends)is_val_statically_knownfor floats #129173 (Fixis_val_statically_knownfor floats)run-make/libtest-json/validate_json.pyto Rust #129185 (Portrun-make/libtest-json/validate_json.pyto Rust)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup