Docify std::vec_ng #12955
Docify std::vec_ng #12955
Conversation
| @@ -40,7 +40,7 @@ case. | |||
| An example is the method `.slice(a, b)` that returns an immutable "view" into | |||
| a vector or a vector slice from the index interval `[a, b)`: | |||
|
|
|||
| ```rust | |||
| ``rust | |||
|
This documentation was all mostly copied from |
|
Most of the text was, but I think most of the examples are new.. |
|
|
||
| /// An owned, growable vector | ||
| /// | ||
| /// `Vec<T>` is the replacement for the deprecated `~[T]` type. The API is |
There was a problem hiding this comment.
I don't think this should mention ~[T]. This belongs in the 0.10 release notes + extended release notes, and is already a lint. This documentation will just become outdated.
There was a problem hiding this comment.
I'll get rid of that when I expand that section of the docs.
On Mar 16, 2014 5:25 PM, "Daniel Micay" notifications@github.com wrote:
In src/libstd/vec_ng.rs:
@@ -32,8 +28,21 @@ use ptr;
use rt::global_heap::{malloc_raw, realloc_raw};
use raw::Slice;
use vec::{ImmutableEqVector, ImmutableVector, Items, MutItems, MutableVector};-use vec::{RevItems};
+use vec::{MutableTotalOrdVector};
+
+/// An owned, growable vector
+///
+///Vec<T>is the replacement for the deprecated~[T]type. The API isI don't think this should mention ~[T]. This belongs in the 0.10 release
notes + extended release notes, and is already a lint. This documentation
will just become outdated.Reply to this email directly or view it on GitHubhttps://github.com//pull/12955/files#r10643022
.
I also removed a couple of methods that were silly and added sort.
I also removed a couple of methods that were silly and added sort.
feat: Display the value of enum variant on hover fixes rust-lang#12955 This PR adds const eval support for enums, as well as showing their value on hover, just as consts currently have. I developed these two things at the same time, but I've realized now that they are separate. However since the hover is just a 10 line change (not including tests), I figured I may as well put them in the same PR. Though if you want them split up into "enum const eval support" and "show enum variant value on hover", I think that's reasonable too. Since this adds const eval support for enums this also allows consts that reference enums to have their values computed now too. The const evaluation itself is quite rudimentary, it doesn't keep track of the actual type of the enum, but it turns out that Rust doesn't actually either, and `E::A as u8` is valid regardless of the `repr` on `E`. It also doesn't really care about what expression the enum variant contains, it could for example be a string, despite that not being allowed, but I guess it's up to the `cargo check` diagnostics to inform of such issues anyway?
I also removed a couple of methods that were silly and added sort.