Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 8 pull requests #129591

Closed
wants to merge 34 commits into from

Commits on Aug 20, 2024

  1. Configuration menu
    Copy the full SHA
    a97b41f View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2024

  1. Configuration menu
    Copy the full SHA
    147bb17 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2024

  1. Configuration menu
    Copy the full SHA
    e7f11b6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c29e328 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    51cd76b View commit details
    Browse the repository at this point in the history
  4. elided_named_lifetimes: Lint stub

    Currently ICEs because we buffer it with NodeId of the missing lifetime,
    so it ends up not getting emitted
    GrigorenkoPV committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    40d8379 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    19d11db View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    f735c7a View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    4328e8b View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    7a73ed4 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    3dac6f9 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    b977633 View commit details
    Browse the repository at this point in the history
  11. Rename allow_elided_static to warn_elided_static for clarity

    So that you know it's about linting and not about correctness.
    
    Yes, it is also inverted now.
    GrigorenkoPV committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    a57ebc3 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    bec8f58 View commit details
    Browse the repository at this point in the history
  13. bless tests

    GrigorenkoPV committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    2822aff View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    0b37f75 View commit details
    Browse the repository at this point in the history
  15. Bless clippy tests

    GrigorenkoPV committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    3175fac View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    7e74a5e View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    610f1a5 View commit details
    Browse the repository at this point in the history
  18. TyCtxt::item_name exists

    GrigorenkoPV committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    bacbf46 View commit details
    Browse the repository at this point in the history
  19. Move the override flag for elided_named_lifetimes

    from `LateResolutionVisitor` to `LifetimeRes::Static`
    GrigorenkoPV committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    f0c9cec View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    3a7d0ab View commit details
    Browse the repository at this point in the history
  21. tweak rustc_allow_const_fn_unstable hint, and add back test for stabl…

    …e-const-can-only-call-stable-const
    RalfJung committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    ba24121 View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    8750e24 View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    48f43fa View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    ecd2d11 View commit details
    Browse the repository at this point in the history
  25. Rollup merge of rust-lang#129207 - GrigorenkoPV:elided-is-named, r=cj…

    …gillot
    
    Lint that warns when an elided lifetime ends up being a named lifetime
    
    As suggested in rust-lang#48686 (comment)
    
    Fixes rust-lang#48686
    
    ## TODO:
    - [ ] Crater run?
    
    ## Questions:
    - [ ] Should we separate the `'static` case and the named lifetime parameter case?
    - [ ] Should this be `Allow` or `Warn` by default?
    - [ ] Should this be gated behind an edition?
    
    ## Future improvemetns:
    - [ ] Add machine-applicable suggestions
    
    `@rustbot` label A-lint
    matthiaskrgr committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    4e1a70f View commit details
    Browse the repository at this point in the history
  26. Rollup merge of rust-lang#129288 - compiler-errors:unsafe-fn-coercion…

    …, r=lcnr
    
    Use subtyping for `UnsafeFnPointer` coercion, too
    
    I overlooked this in rust-lang#129059, which changed MIR typechecking to use subtyping for other fn pointer coercions.
    
    Fixes rust-lang#129285
    matthiaskrgr committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    e7aca53 View commit details
    Browse the repository at this point in the history
  27. Rollup merge of rust-lang#129405 - surechen:fix_span_x, r=cjgillot

    Fixing span manipulation and indentation of the suggestion introduced by rust-lang#126187
    
    According to comments:
    rust-lang#128084 (comment)
    https://github.com/rust-lang/rust/pull/126187/files#r1634897691
    matthiaskrgr committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    614ea5a View commit details
    Browse the repository at this point in the history
  28. Rollup merge of rust-lang#129518 - GrigorenkoPV:gitignore-library-ice…

    …, r=tgross35
    
    gitignore: ignore ICE reports regardless of directory
    
    Quite often when working on compiler I end up running into ICEs during the standard library compilation.
    
    These ICEs generate reports in `/library/` and not at the root of the repo, so they aren't `gitignore`d.
    
    I finally ended up committing one today, by accident: rust-lang#129487 (comment)
    matthiaskrgr committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    1fe4b67 View commit details
    Browse the repository at this point in the history
  29. Rollup merge of rust-lang#129519 - compiler-errors:lowering-flags, r=…

    …fmease
    
    Remove redundant flags from `lower_ty_common` that can be inferred from the HIR
    
    ...and then get rid of `lower_ty_common`.
    
    r? `@fmease` or re-roll if you're busy!
    matthiaskrgr committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    8a1fff1 View commit details
    Browse the repository at this point in the history
  30. Rollup merge of rust-lang#129544 - mu001999-contrib:dead-code/clean, …

    …r=compiler-errors
    
    Removes dead code from the compiler
    
    Detected by rust-lang#128637
    matthiaskrgr committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    65baca7 View commit details
    Browse the repository at this point in the history
  31. Rollup merge of rust-lang#129553 - RalfJung:const-stability, r=compil…

    …er-errors
    
    add back test for stable-const-can-only-call-stable-const
    
    This got accidentally removed in rust-lang#128596 (file `tests/ui/internal/internal-unstable-const.rs`). The test has little to do with "allow internal unstable" though, so add it in a file that already tests various const stability things.
    
    Also tweak the help that suggests to add `rustc_allow_const_fn_unstable` to make it clear that this needs team approval, since it is a fairly big gun.
    matthiaskrgr committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    b8e8a10 View commit details
    Browse the repository at this point in the history
  32. Rollup merge of rust-lang#129590 - compiler-errors:ref-tykind, r=fmease

    Avoid taking reference of &TyKind
    
    It's already a ref anyways. Just a tiny cleanup here.
    matthiaskrgr committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    1bac9b2 View commit details
    Browse the repository at this point in the history