Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 11 pull requests #129691

Merged
merged 28 commits into from
Aug 28, 2024
Merged

Rollup of 11 pull requests #129691

merged 28 commits into from
Aug 28, 2024

Commits on Aug 23, 2024

  1. Configuration menu
    Copy the full SHA
    d7e7886 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2024

  1. Configuration menu
    Copy the full SHA
    a772db4 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2024

  1. Configuration menu
    Copy the full SHA
    7ea2981 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7a290fc View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2024

  1. rustdoc: fix missing resource suffix on crates.js

    Fixes a regression introduced in rust-lang#128252.
    notriddle committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    a1746b4 View commit details
    Browse the repository at this point in the history
  2. safe transmute: Rename BikeshedIntrinsicFrom to TransmuteFrom

    As our implementation of MCP411 nears completion and we begin to
    solicit testing, it's no longer reasonable to expect testers to
    type or remember `BikeshedIntrinsicFrom`. The name degrades the
    ease-of-reading of documentation, and the overall experience of
    using compiler safe transmute.
    
    Tentatively, we'll instead adopt `TransmuteFrom`.
    
    This name seems to be the one most likely to be stabilized, after
    discussion on Zulip [1]. We may want to revisit the ordering of
    `Src` and `Dst` before stabilization, at which point we'd likely
    consider `TransmuteInto` or `Transmute`.
    
    [1] https://rust-lang.zulipchat.com/#narrow/stream/216762-project-safe-transmute/topic/What.20should.20.60BikeshedIntrinsicFrom.60.20be.20named.3F
    jswrenn committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    1ad218f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c3000ad View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a507ec6 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    e17be95 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    0d6c915 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2024

  1. replace is_some() -> unwrap with if let

    Orion Gonzalez committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    ddcb073 View commit details
    Browse the repository at this point in the history
  2. cleanup make_input

    Orion Gonzalez committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    b218623 View commit details
    Browse the repository at this point in the history
  3. clarify a few things

    Orion Gonzalez committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    a007d34 View commit details
    Browse the repository at this point in the history
  4. clarify what term can be

    Orion Gonzalez committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    c35e01e View commit details
    Browse the repository at this point in the history
  5. coverage: CodeRegion is never stored in an arena

    This might have been left over when coverage regions were stored in individual
    MIR statements, instead of a separate table attached to the MIR body.
    Zalathar committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    f61f34f View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    5e162a8 View commit details
    Browse the repository at this point in the history
  7. coverage: Rename CodeRegion to SourceRegion

    LLVM uses the word "code" to refer to a particular kind of coverage mapping.
    This unrelated usage of the word is confusing, and makes it harder to introduce
    types whose names correspond to the LLVM classification of coverage kinds.
    Zalathar committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    46e1b5b View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#129421 - jdonszelmann:naked-repr-align-func…

    …tions, r=workingjubilee,compiler-errors
    
    add repr to the allowlist for naked functions
    
    Fixes rust-lang#129412 (combining unstable features rust-lang#90957 (`#![feature(naked_functions)]`) and rust-lang#82232 (`#![feature(fn_align)]`)
    matthiaskrgr committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    99453ce View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#129480 - lolbinarycat:euclid-docs, r=joboet

    docs: correct panic conditions for rem_euclid and similar functions
    
    fixes rust-lang#128857
    
    also fixes the documentation for functions behind the `int_roundings` feature (rust-lang#88581)
    matthiaskrgr committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    56ca2e2 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#129551 - RalfJung:ub-checks-fallback, r=sae…

    …thlin
    
    ub_checks intrinsics: fall back to cfg(ub_checks)
    
    Not sure why the fallback body uses `debug_assertions`, probably a leftover from when `cfg!(ub_checks)` did not exist yet?
    
    r? `@saethlin`
    matthiaskrgr committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    0156208 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#129608 - RalfJung:const-eval-ub-checks, r=s…

    …aethlin
    
    const-eval: do not make UbChecks behavior depend on current crate's flags
    
    Fixes rust-lang#129552
    
    Let's see if we can get away with just always enabling these checks.
    matthiaskrgr committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    3456b1d View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#129613 - RalfJung:interpret-target-feat, r=…

    …saethlin
    
    interpret: do not make const-eval query result depend on tcx.sess
    
    The check against calling functions with missing target features uses `tcx.sess` to determine which target features are available. However, this can differ between different crates in a crate graph, so the same const-eval query can come to different conclusions about whether a constant evaluates successfully or not -- which is bad, we should consistently get the same result everywhere.
    matthiaskrgr committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    39e840f View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#129641 - notriddle:notriddle/missing-crates…

    …-js-resource-suffix, r=GuillaumeGomez
    
    rustdoc: fix missing resource suffix on `crates.js`
    
    Fixes a regression introduced in rust-lang#128252.
    matthiaskrgr committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    5725119 View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#129657 - jswrenn:transmute-name, r=compiler…

    …-errors
    
    Rename `BikeshedIntrinsicFrom` to `TransmuteFrom`
    
    As our implementation of MCP411 nears completion and we begin to solicit testing, it's no longer reasonable to expect testers to type or remember `BikeshedIntrinsicFrom`. The name degrades the ease-of-reading of documentation, and the overall experience of using compiler safe transmute.
    
    Tentatively, we'll instead adopt `TransmuteFrom`.
    
    This name seems to be the one most likely to be stabilized, after discussion on Zulip [1]. We may want to revisit the ordering of `Src` and `Dst` before stabilization, at which point we'd likely consider `TransmuteInto` or `Transmute`.
    
    [1] https://rust-lang.zulipchat.com/#narrow/stream/216762-project-safe-transmute/topic/What.20should.20.60BikeshedIntrinsicFrom.60.20be.20named.3F
    
    Tracking Issue: rust-lang#99571
    
    r​? `@compiler-errors`
    matthiaskrgr committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    29188a5 View commit details
    Browse the repository at this point in the history
  15. Rollup merge of rust-lang#129666 - RalfJung:raw-eq-align, r=compiler-…

    …errors
    
    interpret: add missing alignment check in raw_eq
    
    The intrinsic requires alignment, but we forgot to check for that in Miri and const-eval.
    matthiaskrgr committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    5c2996d View commit details
    Browse the repository at this point in the history
  16. Rollup merge of rust-lang#129667 - dev-ardi:rustc_driver-cleanup, r=m…

    …ichaelwoerister
    
    Rustc driver cleanup
    
    This adds a few comments to the driver to clarify a bit what's happening and does some cleanup.
    matthiaskrgr committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    472c964 View commit details
    Browse the repository at this point in the history
  17. Rollup merge of rust-lang#129668 - coolreader18:fix-pin-set-regr, r=d…

    …tolnay
    
    Fix Pin::set bounds regression
    
    Fixes rust-lang#129601
    
    Fixes the regression from rust-lang#129449, where changing the bounds of the impl block containing `Pin::set` changed the method resolution behavior.
    
    ```rust
    struct A;
    impl A {
        fn set(&self) {}
    }
    
    let a: Pin<&A>;
    a.set();
    // before:
    // - checks <impl<Ptr: DerefMut> Pin<Ptr>>::set(): `&A` doesn't impl `DerefMut`
    // - autorefs -> &A: resolves to A::set()
    // now:
    // - checks <impl<Ptr: Deref> Pin<Ptr>>::set(): `&A` impls `Deref`! resolves to Pin::set()
    // - check method bounds: `&A` doesn't impl DerefMut: error
    ```
    
    r? `@dtolnay`
    matthiaskrgr committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    27d7fb0 View commit details
    Browse the repository at this point in the history
  18. Rollup merge of rust-lang#129686 - Zalathar:source-region, r=compiler…

    …-errors
    
    coverage: Rename `CodeRegion` to `SourceRegion`
    
    LLVM uses the word "code" to refer to a particular kind of coverage mapping. This unrelated usage of the word is confusing, and makes it harder to introduce types whose names correspond to the LLVM classification of coverage kinds.
    
    No functional changes.
    matthiaskrgr committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    4854fa7 View commit details
    Browse the repository at this point in the history