Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 11 pull requests #129705

Closed
wants to merge 28 commits into from

Commits on Aug 16, 2024

  1. Configuration menu
    Copy the full SHA
    8bc120a View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2024

  1. Configuration menu
    Copy the full SHA
    515f5ac View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2024

  1. Configuration menu
    Copy the full SHA
    70ba8c1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    42a901a View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2024

  1. Update books

    rustbot committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    834d615 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a673e4f View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2024

  1. Improve isqrt tests and add benchmarks

    * Choose test inputs more thoroughly and systematically.
    * Check that `isqrt` and `checked_isqrt` have equivalent results for
      signed types, either equivalent numerically or equivalent as a panic
      and a `None`.
    * Check that `isqrt` has numerically-equivalent results for unsigned
      types and their `NonZero` counterparts.
    * Reuse `ilog10` benchmarks, plus benchmarks that use a uniform
      distribution.
    ChaiTRex committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    fcb04b8 View commit details
    Browse the repository at this point in the history
  2. Speed up checked_isqrt and isqrt methods

    * Use a lookup table for 8-bit integers and the Karatsuba square root
      algorithm for larger integers.
    * Include optimization hints that give the compiler the exact numeric
      range of results.
    ChaiTRex committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    8e54e87 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a1c36c6 View commit details
    Browse the repository at this point in the history
  4. linker: Better support alternative static library naming on MSVC

    Previously `libname.a` naming was supported as a fallback when producing rlibs, but not when producing executables or dynamic libraries
    petrochenkov committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    05bd36d View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    ac8f132 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2024

  1. Add fmt::Debug to sync::Weak<T, A>

    Matthew Giordano committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    c11d46f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0589dc7 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4e6cd0f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    19296ca View commit details
    Browse the repository at this point in the history
  5. Update reference

    ehuss committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    7c4cc9f View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    3914835 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#128166 - ChaiTRex:isqrt, r=tgross35

    Improved `checked_isqrt` and `isqrt` methods
    
    ### Improved tests of `isqrt` and `checked_isqrt` implementations
    
    * Inputs chosen more thoroughly and systematically.
    * Checks that `isqrt` and `checked_isqrt` have equivalent results for signed types, either equivalent numerically or equivalent as a panic and a `None`.
    * Checks that `isqrt` has numerically-equivalent results for unsigned types and their `NonZero` counterparts.
    
    ### Added benchmarks for `isqrt` implementations
    
    ### Greatly sped up `checked_isqrt` and `isqrt` methods
    
    * Uses a lookup table for 8-bit integers and then the Karatsuba square root algorithm for larger integers.
    * Includes optimization hints that give the compiler the exact numeric range of results.
    
    ### Feature tracking issue
    
    `isqrt` is an unstable feature tracked at rust-lang#116226.
    
    <details><summary>Benchmarked improvements</summary>
    
    ### Command used to benchmark
    
        ./x bench library/core -- int_sqrt
    
    ### Before
    
        benchmarks:
            num::int_sqrt::i128::isqrt           439591.65/iter  +/- 6652.70
            num::int_sqrt::i16::isqrt              5302.97/iter   +/- 160.93
            num::int_sqrt::i32::isqrt             62999.11/iter  +/- 2022.05
            num::int_sqrt::i64::isqrt            125248.81/iter  +/- 1674.43
            num::int_sqrt::i8::isqrt                123.56/iter     +/- 1.87
            num::int_sqrt::isize::isqrt          125356.56/iter  +/- 1017.03
            num::int_sqrt::non_zero_u128::isqrt  437443.75/iter  +/- 3535.43
            num::int_sqrt::non_zero_u16::isqrt     8604.58/iter    +/- 94.76
            num::int_sqrt::non_zero_u32::isqrt    62933.33/iter   +/- 517.30
            num::int_sqrt::non_zero_u64::isqrt   125076.38/iter +/- 11340.61
            num::int_sqrt::non_zero_u8::isqrt       221.51/iter     +/- 1.58
            num::int_sqrt::non_zero_usize::isqrt 136005.21/iter  +/- 2020.35
            num::int_sqrt::u128::isqrt           439014.55/iter  +/- 3920.45
            num::int_sqrt::u16::isqrt              8575.08/iter   +/- 148.06
            num::int_sqrt::u32::isqrt             63008.89/iter   +/- 803.67
            num::int_sqrt::u64::isqrt            125088.09/iter   +/- 879.29
            num::int_sqrt::u8::isqrt                230.18/iter     +/- 2.04
            num::int_sqrt::usize::isqrt          125237.51/iter  +/- 4747.83
    ### After
    
        benchmarks:
            num::int_sqrt::i128::isqrt           105184.89/iter +/- 1171.38
            num::int_sqrt::i16::isqrt              1910.26/iter   +/- 78.50
            num::int_sqrt::i32::isqrt             34260.34/iter  +/- 960.84
            num::int_sqrt::i64::isqrt             45939.19/iter +/- 2525.65
            num::int_sqrt::i8::isqrt                 22.87/iter    +/- 0.45
            num::int_sqrt::isize::isqrt           45884.17/iter  +/- 595.49
            num::int_sqrt::non_zero_u128::isqrt  106344.27/iter  +/- 780.99
            num::int_sqrt::non_zero_u16::isqrt     2790.19/iter   +/- 53.43
            num::int_sqrt::non_zero_u32::isqrt    33613.99/iter  +/- 362.96
            num::int_sqrt::non_zero_u64::isqrt    46235.42/iter  +/- 429.69
            num::int_sqrt::non_zero_u8::isqrt        31.78/iter    +/- 0.75
            num::int_sqrt::non_zero_usize::isqrt  46208.75/iter  +/- 375.27
            num::int_sqrt::u128::isqrt           106385.94/iter +/- 1649.95
            num::int_sqrt::u16::isqrt              2747.69/iter   +/- 28.72
            num::int_sqrt::u32::isqrt             33627.09/iter  +/- 475.68
            num::int_sqrt::u64::isqrt             46182.29/iter  +/- 311.16
            num::int_sqrt::u8::isqrt                 33.10/iter    +/- 0.30
            num::int_sqrt::usize::isqrt           46165.00/iter  +/- 388.41
    
    </details>
    matthiaskrgr committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    7351061 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#129170 - artemagvanian:span-to-location, r=…

    …celinval
    
    Add an ability to convert between `Span` and `visit::Location`
    
    AFAIK, there is no way to create a `Location` from a `Span` because its only field is private. This makes it impossible to use visitor methods like `visit_statement` or `visit_terminator`.
    
    This PR adds an implementation for`From<Span>` for `Location` to fix this.
    
    r? `@celinval`
    matthiaskrgr committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    c5cd00e View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#129366 - petrochenkov:libsearch, r=jieyouxu

    linker: Synchronize native library search in rustc and linker
    
    Also search for static libraries with alternative naming (`libname.a`) on MSVC when producing executables or dynamic libraries, and not just rlibs.
    
    This unblocks rust-lang#123436.
    
    try-job: x86_64-msvc
    matthiaskrgr committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    c3c38c6 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#129467 - dingxiangfei2009:smart-pointer-rel…

    …ax-pointee, r=compiler-errors
    
    derive(SmartPointer): assume pointee from the single generic and better error messages
    
    Fix rust-lang#129465
    
    Actually RFC says that `#[pointee]` can be inferred when there is no ambiguity, or there is only one generic type parameter so to say.
    
    cc `@Darksonn`
    
    r? `@compiler-errors`
    matthiaskrgr committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    4168c39 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#129494 - tshepang:fmt-threads-sendsync, r=N…

    …adrieril
    
    format code in tests/ui/threads-sendsync
    
    was thinking of fixing formatting for 1 test in the directory, but found a bunch of them to also be in need
    matthiaskrgr committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    c308663 View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#129527 - compiler-errors:lint-nit, r=Nadrieril

    Don't use `TyKind` in a lint
    
    Allows us to remove an inherent method from `TyKind` from the type ir crate.
    matthiaskrgr committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    0a0ee7e View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#129617 - rustbot:docs-update, r=ehuss

    Update books
    
    ## rust-lang/book
    
    4 commits in 04bc1396bb857f35b5dda1d773c9571e1f253304..e7d217be2a75ef1753f0988d6ccaba4d7e376259
    2024-08-14 01:19:47 UTC to 2024-08-13 16:51:00 UTC
    
    - Backport/forward port ch12 (rust-lang/book#4008)
    - Found some more things to fix in ch7; I forgot to update the snapshot (rust-lang/book#4007)
    - Remove redundant sentence. Send to nostarch (rust-lang/book#4006)
    - Fix: typo (rust-lang/book#4003)
    
    ## rust-lang/edition-guide
    
    5 commits in aeeb287d41a0332c210da122bea8e0e91844ab3e..eeba2cb9c37ab74118a4fb5e5233f7397e4a91f8
    2024-08-19 23:28:06 UTC to 2024-08-15 15:12:33 UTC
    
    - 2024: Add rustdoc combined doctests (rust-lang/edition-guide#320)
    - Update for unsafe attributes stabilization (rust-lang/edition-guide#319)
    - 2024: Add macro-fragment-specifiers. (rust-lang/edition-guide#312)
    - Fix deprecated_safe_2024 link (rust-lang/edition-guide#317)
    - Add 2024 unsafe functions (rust-lang/edition-guide#304)
    
    ## rust-embedded/book
    
    1 commits in 019f3928d8b939ec71b63722dcc2e46330156441..ff5d61d56f11e1986bfa9652c6aff7731576c37d
    2024-08-20 07:26:19 UTC to 2024-08-20 07:26:19 UTC
    
    - Use aligned address to demonstrate HardFault (rust-embedded/book#374)
    
    ## rust-lang/nomicon
    
    1 commits in 6ecf95c5f2bfa0e6314dfe282bf775fd1405f7e9..14649f15d232d509478206ee9ed5105641aa60d0
    2024-08-14 14:49:09 UTC to 2024-08-14 14:49:09 UTC
    
    - CI: Switch to merge queue (rust-lang/nomicon#459)
    
    ## rust-lang/reference
    
    14 commits in 62cd0df95061ba0ac886333f5cd7f3012f149da1..0668397076da350c404dadcf07b6cbc433ad3743
    2024-08-11 21:06:12 +0000 to 2024-08-27 21:47:20 +0000
    - Update enum.md (rust-lang/reference#1354)
    - Be consistent about how "Edition differences" is capitalized (rust-lang/reference#1586)
    - Sync denied lints with upstream (rust-lang/reference#1589)
    - const_eval: update for const-fn float stabilization (rust-lang/reference#1566)
    - Add spec identifier syntax to destructors.md (rust-lang/reference#1571)
    - Say that `pub(in path)` can't depend on `use` statements (rust-lang/reference#1559)
    - bytes inside implicitly const-promoted expressions are immutable (rust-lang/reference#1554)
    - Tweak `repr(transparent)` to mention requiring *at most* one non-1-ZST (rust-lang/reference#1568)
    - operator expressions: add &raw (rust-lang/reference#1567)
    - Rewrite the automatic std link translation, and switch to automatic links (rust-lang/reference#1578)
    - Add some basic docs for unsafe attrs (rust-lang/reference#1539)
    - don't capitalize Undefined Behavior (rust-lang/reference#1575)
    - add the `const` operand to docs for inline assembly (rust-lang/reference#1556)
    - Typo: 'a' to 'an' in type-coercions.md (rust-lang/reference#1572)
    
    ## rust-lang/rust-by-example
    
    1 commits in 8f94061936e492159f4f6c09c0f917a7521893ff..859786c5bc99301bbc22fc631a5c2b341860da08
    2024-08-26 10:30:48 UTC to 2024-08-26 10:30:48 UTC
    
    - Update primitives.md with examples (rust-lang/rust-by-example#1878)
    
    ## rust-lang/rustc-dev-guide
    
    7 commits in 43d83780db545a1ed6d45773312fc578987e3968..fa928a6d19e1666d8d811dfe3fd35cdad3b4e459
    2024-08-26 14:46:50 UTC to 2024-08-12 21:07:49 UTC
    
    - Fix x.py reference (rust-lang/rustc-dev-guide#2049)
    - Update `stabilization_guide.md` (rust-lang/rustc-dev-guide#2034)
    - Explain the internal `#[rustc_*]` TEST attributes used for debugging and inside tests (rust-lang/rustc-dev-guide#2046)
    - missing char (rust-lang/rustc-dev-guide#2047)
    - Replace direct http links to rustc-dev-guide.rust-lang.org (rust-lang/rustc-dev-guide#2044)
    - Update index.html, 39. The MIR: fix typo (rust-lang/rustc-dev-guide#2043)
    - Update LLVM docs (rust-lang/rustc-dev-guide#2039)
    matthiaskrgr committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    4d73c9d View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#129673 - matthewpipie:arc-weak-debug-trait,…

    … r=dtolnay
    
    Add fmt::Debug to sync::Weak<T, A>
    
    Currently, `sync::Weak<T>` implements `Debug`, but `sync::Weak<T, A>` does not. This appears to be an oversight, as `rc::Weak<T, A>` implements `Debug`. (Note: `sync::Weak` is the weak for `Arc`, and `rc::Weak` is the weak for `Rc`.)
    
    This PR adds the Debug trait for `sync::Weak<T, A>`. The issue was initially brought up here: rust-lang/wg-allocators#131
    matthiaskrgr committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    356746c View commit details
    Browse the repository at this point in the history
  15. Rollup merge of rust-lang#129683 - RalfJung:copysign, r=thomcc

    copysign with sign being a NaN can have non-portable results
    
    Follow-up to rust-lang#129559.
    Cc `@tgross35` `@beetrees`
    
    There's no portable variant we can recommend instead here, is there? Something with a semantics like "if `sign` is a NaN, then return `self` unaltered, otherwise return `self` with the sign changed to that of `sign`"?
    matthiaskrgr committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    3489ec4 View commit details
    Browse the repository at this point in the history
  16. Rollup merge of rust-lang#129689 - compiler-errors:impl-lifetime, r=m…

    …ichaelwoerister
    
    Move `'tcx` lifetime off of impl and onto methods for `CrateMetadataRef`
    
    Unconstrained type and const variables are not allowed, but unconstrained lifetimes are. This is not very good style, though, and it leads to unnecessary captures of a lifetime in edition 2024 (not that it matters, but it does trigger the edition migration lint).
    matthiaskrgr committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    983887d View commit details
    Browse the repository at this point in the history
  17. Rollup merge of rust-lang#129695 - GuillaumeGomez:fix-clippy-rustdoc-…

    …path, r=onur-ozkan
    
    Fix path to run clippy on rustdoc
    
    Took me a while to find out that the path clippy expected was `src/tools/rustdoc` and not `src/librustdoc`. I think it makes more sense this way as most commands rely on source paths.
    
    r? `@Kobzol`
    matthiaskrgr committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    7320663 View commit details
    Browse the repository at this point in the history