Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand NLL MIR dumps #129711

Merged
merged 5 commits into from
Aug 31, 2024
Merged

Expand NLL MIR dumps #129711

merged 5 commits into from
Aug 31, 2024

Commits on Aug 30, 2024

  1. introduce PrettyPrintMirOptions for cosmetic MIR dump options 

    initially starting with `-Z mir-include-spans` because we want them in
the NLL mir dump pass
    @lqd
    lqd committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    c646b46 View commit details
    Browse the repository at this point in the history

  2. make -Z mir-include-spans a dedicated enum 

    We want to allow setting this on the CLI, override it only in MIR
passes, and disable it altogether in mir-opt tests.

The default value is "only for NLL MIR dumps", which is considered off
for all intents and purposes, except for `rustc_borrowck` when an NLL
MIR dump is requested.
    @lqd
    lqd committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    e0bb1c7 View commit details
    Browse the repository at this point in the history

  3. enable extra comments in NLL MIR dumps

    @lqd
    lqd committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    92e1046 View commit details
    Browse the repository at this point in the history

  4. refactor NLL MIR dump entry point

    @lqd
    lqd committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    f3f5b4d View commit details
    Browse the repository at this point in the history

  5. add borrows to NLL MIR dumps 

    explicitly disable `-Zmir-include-spans` in mir-opt tests

This will override the NLL default of true, and keep the blessed dumps
easier to work with.
    @lqd
    lqd committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    dff3d35 View commit details
    Browse the repository at this point in the history