Subpart10 for async drop (major4) - StateTransform pass improvements #129746
+2,471
−2,076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
This was referenced Aug 29, 2024
azhogin
force-pushed
the
azhogin/async-drop-subpart10-state-transform
branch
from
b52aadb
to
c57d5af
Compare
…p from previous async drop glue implementation
azhogin
force-pushed
the
azhogin/async-drop-subpart10-state-transform
branch
from
c57d5af
to
cbd1df8
Compare
azhogin
force-pushed
the
azhogin/async-drop-subpart10-state-transform
branch
from
cbd1df8
to
871da65
Compare
|
☔ The latest upstream changes (presumably #130165) made this pull request unmergeable. Please resolve the merge conflicts. |
|
r? @nikomatsakis is going to look into this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is subpart 10 PR of #123948, just for review purposes.
Async drop in StateTransform pass may be expanded into additional yield point or reset to sync version (
dropandasync_futterminator fields reset toNone).Added generation of async drop poll function for coroutine itself (
create_coroutine_drop_shim_async).Review only last commit, based on previous PR #129745.