Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use sysroot crates maximally in rustc_codegen_gcc. #129876

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Use sysroot crates maximally in rustc_codegen_gcc. #129876

merged 1 commit into from
Sep 9, 2024

Conversation

nnethercote
Copy link
Contributor

@nnethercote nnethercote commented Sep 2, 2024 •
edited
Loading

This shrinks compiler/rustc_codegen_gcc/Cargo.lock quite a bit. The only remaining dependencies in compiler/rustc_codegen_gcc/Cargo.lock are gccjit, lang_tester, and boml, all of which aren't used in any other compiler crates.

The commit also reorders and adds comments to the extern crate items so they match those in miri.

r? @Mark-Simulacrum

@nnethercote
Use sysroot crates maximally in rustc_codegen_gcc.
747f680 
This shrinks `compiler/rustc_codegen_gcc/Cargo.lock` quite a bit. The
only remaining dependencies in `compiler/rustc_codegen_gcc/Cargo.lock`
are `gccjit`, `lang_tester`, and `boml`, all of which aren't used in any
other compiler crates.

The commit also reorders and adds comments to the `extern crate` items
so they match those in miri.
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 2, 2024
@rustbot
Copy link
Collaborator

rustbot commented Sep 2, 2024

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo, @GuillaumeGomez

@nnethercote nnethercote mentioned this pull request Sep 2, 2024
Closed
@rust-lang rust-lang deleted a comment from rustbot Sep 2, 2024
@nnethercote
Copy link
Contributor Author

In #129768 I tried removing extern crate tracing from rustc_codegen_gcc, which required adding it to compiler/rustc_codegen_gcc/Cargo.toml, which resulted in compiler/rustc_codegen_gcc/Cargo.lock getting additional entries, which @antoyo didn't like. So now I have gone in the other direction. I don't have much sense of whether this matters. Might it make the the distributed artifacts smaller?

@rust-lang rust-lang deleted a comment from rustbot Sep 2, 2024
antoyo
antoyo approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@antoyo antoyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thank you!

@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Sep 7, 2024

📌 Commit 747f680 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 7, 2024
@nnethercote
Copy link
Contributor Author

@bors rollup

workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Sep 9, 2024
@workingjubilee
Rollup merge of rust-lang#129876 - nnethercote:more-sysroot-rustc_cod…
0785e3d 
…egen_gcc, r=Mark-Simulacrum

Use sysroot crates maximally in `rustc_codegen_gcc`.

This shrinks `compiler/rustc_codegen_gcc/Cargo.lock` quite a bit. The only remaining dependencies in `compiler/rustc_codegen_gcc/Cargo.lock` are `gccjit`, `lang_tester`, and `boml`, all of which aren't used in any other compiler crates.

The commit also reorders and adds comments to the `extern crate` items so they match those in miri.

r? `@Mark-Simulacrum`
@workingjubilee workingjubilee mentioned this pull request Sep 9, 2024
Closed
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Sep 9, 2024
@workingjubilee
Rollup merge of rust-lang#129876 - nnethercote:more-sysroot-rustc_cod…
339407d 
…egen_gcc, r=Mark-Simulacrum

Use sysroot crates maximally in `rustc_codegen_gcc`.

This shrinks `compiler/rustc_codegen_gcc/Cargo.lock` quite a bit. The only remaining dependencies in `compiler/rustc_codegen_gcc/Cargo.lock` are `gccjit`, `lang_tester`, and `boml`, all of which aren't used in any other compiler crates.

The commit also reorders and adds comments to the `extern crate` items so they match those in miri.

r? ``@Mark-Simulacrum``
@workingjubilee workingjubilee mentioned this pull request Sep 9, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 9, 2024
@bors
Auto merge of rust-lang#130129 - workingjubilee:rollup-yfakrkp, r=wor…
23ed20d 
…kingjubilee

Rollup of 16 pull requests

Successful merges:

 - rust-lang#119229 (Update mingw-w64 + GNU toolchain)
 - rust-lang#128345 (added support for GNU/Hurd on x86_64)
 - rust-lang#128667 (rustdoc: normalise type/field names)
 - rust-lang#128939 (Distribute rustc_codegen_cranelift for Windows)
 - rust-lang#129529 (Add test to build crates used by r-a on stable)
 - rust-lang#129624 (Adjust `memchr` pinning and run `cargo update`)
 - rust-lang#129876 (Use sysroot crates maximally in `rustc_codegen_gcc`.)
 - rust-lang#130034 ( Fix enabling wasm-component-ld to match other tools )
 - rust-lang#130048 (run-make-support: Add llvm-pdbutil)
 - rust-lang#130068 (Test codegen when setting deployment target)
 - rust-lang#130070 (Rename variant `AddrOfRegion` of `RegionVariableOrigin` to `BorrowRegion`)
 - rust-lang#130087 (remove 'const' from 'Option::iter')
 - rust-lang#130090 (make Result::copied unstably const)
 - rust-lang#130092 (Fixes typo in wasm32-wasip2 doc comment)
 - rust-lang#130107 (const: make ptr.is_null() stop execution on ambiguity)
 - rust-lang#130115 (Remove needless returns detected by clippy in libraries)

r? `@ghost`
`@rustbot` modify labels: rollup
@workingjubilee workingjubilee mentioned this pull request Sep 9, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 9, 2024
@bors
Auto merge of rust-lang#130133 - workingjubilee:rollup-t5o827k, r=wor…
1f44f0a 
…kingjubilee

Rollup of 14 pull requests

Successful merges:

 - rust-lang#119229 (Update mingw-w64 + GNU toolchain)
 - rust-lang#128345 (added support for GNU/Hurd on x86_64)
 - rust-lang#128667 (rustdoc: normalise type/field names)
 - rust-lang#129876 (Use sysroot crates maximally in `rustc_codegen_gcc`.)
 - rust-lang#130034 ( Fix enabling wasm-component-ld to match other tools )
 - rust-lang#130048 (run-make-support: Add llvm-pdbutil)
 - rust-lang#130068 (Test codegen when setting deployment target)
 - rust-lang#130070 (Rename variant `AddrOfRegion` of `RegionVariableOrigin` to `BorrowRegion`)
 - rust-lang#130087 (remove 'const' from 'Option::iter')
 - rust-lang#130090 (make Result::copied unstably const)
 - rust-lang#130092 (Fixes typo in wasm32-wasip2 doc comment)
 - rust-lang#130107 (const: make ptr.is_null() stop execution on ambiguity)
 - rust-lang#130115 (Remove needless returns detected by clippy in libraries)
 - rust-lang#130130 (Miri subtree update)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 15c7d27 into rust-lang:master Sep 9, 2024
6 checks passed
@rustbot rustbot added this to the 1.83.0 milestone Sep 9, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Sep 9, 2024
@rust-timer
Unrolled build for rust-lang#129876
f62dcc4 
Rollup merge of rust-lang#129876 - nnethercote:more-sysroot-rustc_codegen_gcc, r=Mark-Simulacrum

Use sysroot crates maximally in `rustc_codegen_gcc`.

This shrinks `compiler/rustc_codegen_gcc/Cargo.lock` quite a bit. The only remaining dependencies in `compiler/rustc_codegen_gcc/Cargo.lock` are `gccjit`, `lang_tester`, and `boml`, all of which aren't used in any other compiler crates.

The commit also reorders and adds comments to the `extern crate` items so they match those in miri.

r? ```@Mark-Simulacrum```
@nnethercote nnethercote deleted the more-sysroot-rustc_codegen_gcc branch September 9, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antoyo antoyo antoyo approved these changes

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.83.0
Development

Successfully merging this pull request may close these issues.
5 participants
@nnethercote @rustbot @Mark-Simulacrum @bors @antoyo