Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 9 pull requests #129898

Closed
wants to merge 26 commits into from

Commits on Aug 26, 2024

  1. support custom clippy

    Similar to cargo, rustc, and rustfmt, this adds the support of using custom clippy on bootstrap.
    It’s designed for those who want to test their own clippy builds or avoid downloading the stage0 clippy.
    
    Signed-off-by: onur-ozkan <work@onurozkan.dev>
    onur-ozkan committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    9d694b5 View commit details
    Browse the repository at this point in the history
  2. document build.cargo-clippy option

    Signed-off-by: onur-ozkan <work@onurozkan.dev>
    onur-ozkan committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    9dcc656 View commit details
    Browse the repository at this point in the history
  3. add change entry for custom clippy support

    Signed-off-by: onur-ozkan <work@onurozkan.dev>
    onur-ozkan committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    1a991e5 View commit details
    Browse the repository at this point in the history
  4. Add a run-make test for checking that certain rustc_ crates build o…

    …n stable
    Kobzol authored and lqd committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    893413d View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    7957140 View commit details
    Browse the repository at this point in the history
  6. run test in tmp dir and emit artifacts there

    otherwise the test would build in the source root's `target` folder
    lqd committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    d9794a9 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    2190c28 View commit details
    Browse the repository at this point in the history
  8. separate the crates to test from the test setup

    it'll be easier to see and update the list: the other cmd args
    can just be ignored
    lqd committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    0577035 View commit details
    Browse the repository at this point in the history
  9. remove unneeded type ascription

    lqd committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    f1df0c5 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2024

  1. Configuration menu
    Copy the full SHA
    175238b View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2024

  1. Configuration menu
    Copy the full SHA
    d30b5f0 View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2024

  1. Configuration menu
    Copy the full SHA
    5780c1c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ac69544 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    00de006 View commit details
    Browse the repository at this point in the history
  4. address review comments

    lqd committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    a178559 View commit details
    Browse the repository at this point in the history
  5. Do not request sanitizers for naked functions

    Naked functions can only contain inline asm, so any instrumentation
    inserted by sanitizers is illegal. Don't request it.
    
    Fixes rust-lang#129224.
    nikic committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    cf08447 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    7494224 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#129152 - onur-ozkan:custom-clippy, r=Kobzol

    custom/external clippy support for bootstrapping
    
    Similar to cargo, rustc, and rustfmt, this adds the support of using custom clippy on bootstrap. It’s designed for those who want to test their own clippy builds or avoid downloading the stage0 clippy.
    
    Closes rust-lang#121518
    matthiaskrgr authored Sep 2, 2024
    Configuration menu
    Copy the full SHA
    2dcad58 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#129529 - lqd:stable-new-solver, r=Kobzol

    Add test to build crates used by r-a on stable
    
    r? `@Kobzol`
    
    I've opened other PRs for this one to work and they've landed already. I cherry-picked your commit, and added the last remaining pieces we needed I think.
    matthiaskrgr authored Sep 2, 2024
    Configuration menu
    Copy the full SHA
    9485928 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#129829 - compiler-errors:decode-non-optiona…

    …l, r=lcnr
    
    Make decoding non-optional `LazyArray` panic if not set
    
    Tables may be [defined](https://github.com/rust-lang/rust/blob/9649706eada1b2c68cf6504356efb058f68ad739/compiler/rustc_metadata/src/rmeta/mod.rs#L377) as `optional:` or `defaulted:`. If optional, if we try to read a value from a key that was never encoded, we should panic. This has high value in ensuring correctness over a defaulted table, so the tradeoff is worth considering, since it signals the compiler has a buggy encode impl, rather than just defaulting to a value.
    
    HOWEVER, `optional:` arrays were side-stepping this. So this PR fixes that, and makes `optional:` tables of `LazyArray` act like `LazyValue`, and panic if it's not assigned a value during encoding.
    
    During this PR, I found that `deduced_param_attrs` has buggy (?? i think??) implementation where it will refuse to encode cross-crate `deduced_param_attrs` unless we're codegening, we're optimizing the library, and incremental is disabled. This seems incredibly wrong, but I don't want to fix it in this PR.
    https://github.com/rust-lang/rust/blob/9649706eada1b2c68cf6504356efb058f68ad739/compiler/rustc_metadata/src/rmeta/encoder.rs#L1733-L1747
    matthiaskrgr authored Sep 2, 2024
    Configuration menu
    Copy the full SHA
    aec8ada View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#129860 - lqd:remove-duplicate-deps, r=alexc…

    …richton
    
    update `object` dependency to remove duplicate `wasmparser`
    
    `@alexcrichton` in rust-lang#129762 you bumped a few wasm-related dependencies and tried to avoid duplicates.
    
    If I understand correctly, `object` 0.36.4 wasn't yet released at the time, and therefore rust-lang#129762 ended up duplicating `wasmparser`. Now that the release happened, we can remove the duplicate.
    
    r? `@alexcrichton`
    matthiaskrgr authored Sep 2, 2024
    Configuration menu
    Copy the full SHA
    c67c646 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#129875 - Sajjon:sajjon_fix_typos_batch_1, r…

    …=compiler-errors,jieyouxu
    
    chore: Fix typos in 'compiler' (batch 1)
    
    Batch 1/3: Fixes typos in `compiler`
    
    (See [issue](rust-lang#129874) tracking all PRs with typos fixes)
    matthiaskrgr authored Sep 2, 2024
    Configuration menu
    Copy the full SHA
    9bacd78 View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#129877 - Sajjon:sajjon_fix_typos_batch_2, r…

    …=fee1-dead
    
    chore: Fix typos in 'compiler' (batch 2)
    
    Batch 2/3: Fixes typos in `compiler`
    
    (See [issue](rust-lang#129874) tracking all PRs with typos fixes)
    matthiaskrgr authored Sep 2, 2024
    Configuration menu
    Copy the full SHA
    364135a View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#129878 - Sajjon:sajjon_fix_typos_batch_3, r…

    …=jieyouxu
    
    chore: Fix typos in 'compiler' (batch 3)
    
    Batch 3/3: Fixes typos in `compiler`
    
    (See [issue](rust-lang#129874) tracking all PRs with typos fixes)
    matthiaskrgr authored Sep 2, 2024
    Configuration menu
    Copy the full SHA
    6165b06 View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#129891 - nikic:naked-no-san, r=jackh726

    Do not request sanitizers for naked functions
    
    Naked functions can only contain inline asm, so any instrumentation inserted by sanitizers is illegal. Don't request it.
    
    Fixes rust-lang#129224.
    matthiaskrgr authored Sep 2, 2024
    Configuration menu
    Copy the full SHA
    19a6bf3 View commit details
    Browse the repository at this point in the history
  15. Rollup merge of rust-lang#129892 - oskgo:clarify-slice-from-raw, r=Ra…

    …lfJung
    
    Clarify language around ptrs in slice::raw
    
    More specifically we explicitly mention that the pointer should be non-null as a top level requirement. Nullptrs are always valid for zero sized operations, so just validity (and alignment) does not guarantee non-nullness as implied in the existing docs.
    
    We also explicitly call out ZSTs as an additional example where perhaps unintuitively alignment and non-nullness still have to hold.
    
    Finally we change `data` in the range functions to `start`, which seems like a typo to me.
    
    Touches docs for rust-lang#89792
    
    r? RalfJung
    matthiaskrgr authored Sep 2, 2024
    Configuration menu
    Copy the full SHA
    718b124 View commit details
    Browse the repository at this point in the history