Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: bump actions/checkout to v4 #130124

Closed
wants to merge 1 commit into from
Closed

ci: bump actions/checkout to v4 #130124

wants to merge 1 commit into from

Conversation

trivikr
Copy link
Contributor

@trivikr trivikr commented Sep 8, 2024

@rustbot
Copy link
Collaborator

rustbot commented Sep 8, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @cjgillot (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 8, 2024
@rustbot
Copy link
Collaborator

rustbot commented Sep 8, 2024

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo, @GuillaumeGomez

Portable SIMD is developed in its own repository. If possible, consider making this change to rust-lang/portable-simd instead.

cc @calebzulawski, @programmerjake

Some changes occurred in src/tools/rustfmt

cc @rust-lang/rustfmt

The Miri subtree was changed

cc @rust-lang/miri

@saethlin
Copy link
Member

saethlin commented Sep 8, 2024

This repo already uses actions/checkout@v4, all you did was change the CI configs for a bunch of subtrees, which is a bad idea because those subtrees would get a surprise CI config change when they sync changes back from this repo. Syncing changes from this repo back into a subtree is expected to not fail, because it doesn't contain this kind of shenaniganry.

@saethlin saethlin closed this Sep 8, 2024
@trivikr trivikr deleted the actions-checkout-v4 branch September 9, 2024 00:02
@trivikr
Copy link
Contributor Author

trivikr commented Sep 9, 2024

@saethlin Thanks for detailed response.

I posted PR after searching for usage of Node.js 16.x in popular GitHub repositories, and didn't notice that this change was in subtrees.

I've posted change in CI config rustc_codegen_gcc rust-lang/rustc_codegen_gcc#560 to check if it gets accepted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants