-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bootstrap: Print more debug info when find_initial_libdir
fails
#130138
Conversation
rustbot has assigned @albertlarsan68. Use |
My hypothesis is based on the following:
This is still very speculative, which is why I'm trying to gather more information before taking action. |
75c820e
to
a21f395
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@bors r+ rollup |
Rollup of 5 pull requests Successful merges: - rust-lang#130138 (bootstrap: Print more debug info when `find_initial_libdir` fails) - rust-lang#130199 (Don't call closure_by_move_body_def_id on FnOnce async closures in MIR validation) - rust-lang#130302 (add llvm-bitcode-linker and llvm-tools bins to ci-rustc's sysroot) - rust-lang#130306 (avoid updating LLVM submodule during bootstrap unit tests) - rust-lang#130317 (`ProjectionElem` and `UnOp`/`BinOp` dont need to be `PartialOrd`/`Ord`) r? `@ghost` `@rustbot` modify labels: rollup
Rollup of 5 pull requests Successful merges: - rust-lang#130138 (bootstrap: Print more debug info when `find_initial_libdir` fails) - rust-lang#130199 (Don't call closure_by_move_body_def_id on FnOnce async closures in MIR validation) - rust-lang#130302 (add llvm-bitcode-linker and llvm-tools bins to ci-rustc's sysroot) - rust-lang#130306 (avoid updating LLVM submodule during bootstrap unit tests) - rust-lang#130317 (`ProjectionElem` and `UnOp`/`BinOp` dont need to be `PartialOrd`/`Ord`) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#130138 - Zalathar:initial-libdir, r=albertlarsan68 bootstrap: Print more debug info when `find_initial_libdir` fails From looking at the failure messages printed by rust-lang#129775, my hypothesis is that `rustc --print=sysroot` sometimes prints the wrong path when the rustc executable is hardlinked in multiple places, at least on my macOS system. However, currently I don't have any concrete evidence of this actually happening. This PR therefore expands on rust-lang#129775 by printing even more information on failure (including the actual rustc path), in the hope that when the failure next occurs we can confirm or reject the hypothesis that `rustc --print=sysroot` is printing the wrong path.
Finally witnessed this failing again on my machine:
|
From looking at the failure messages printed by #129775, my hypothesis is that
rustc --print=sysroot
sometimes prints the wrong path when the rustc executable is hardlinked in multiple places, at least on my macOS system.However, currently I don't have any concrete evidence of this actually happening. This PR therefore expands on #129775 by printing even more information on failure (including the actual rustc path), in the hope that when the failure next occurs we can confirm or reject the hypothesis that
rustc --print=sysroot
is printing the wrong path.