Lifetime cleanups #130294
Merged
Lifetime cleanups #130294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does change the external interface, but not in a way that will cause any breakage because external users don't mention the lifetimes.
Giving them more typical names.
- Replace non-standard names like 's, 'p, 'rg, 'ck, 'parent, 'this, and 'me with vanilla 'a. These are cases where the original name isn't really any more informative than 'a. - Replace names like 'cx, 'mir, and 'body with vanilla 'a when the lifetime applies to multiple fields and so the original lifetime name isn't really accurate. - Put 'tcx last in lifetime lists, and 'a before 'b.
|
Could not assign reviewer from: |
rustbot
added
A-query-system
|
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt Some changes occurred to the CTFE / Miri interpreter cc @rust-lang/miri |
oli-obk
approved these changes
Sep 13, 2024
compiler/rustc_passes/src/loops.rs
Outdated
| struct CheckLoopVisitor<'a, 'tcx> { | ||
| sess: &'a Session, | ||
| struct CheckLoopVisitor<'tcx> { | ||
| sess: &'tcx Session, |
There was a problem hiding this comment.
We can get the session from the tcx, the field can be removed
There was a problem hiding this comment.
I've added a commit doing that.
lcnr
reviewed
Sep 13, 2024
There was a problem hiding this comment.
r=me after oli's review.
I feel like this change is right at the edge of whether it's worth it given the potential merge conflicts, reviewer time and what not. So while I think it's an improvement and we should merge this PR, I would not like to review many more PRs like this.
The good news is that this PR does most of the these sorts of possible changes :) |
|
@bors r+ rollup=iffy |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 14, 2024
Rollup of 6 pull requests Successful merges: - rust-lang#130017 (coverage: Extract `executor::block_on` from several async coverage tests) - rust-lang#130268 (simd_shuffle: require index argument to be a vector) - rust-lang#130290 (Stabilize entry_insert) - rust-lang#130294 (Lifetime cleanups) - rust-lang#130343 (docs: Enable required feature for 'closure_returning_async_block' lint) - rust-lang#130349 (Fix `Parser::break_up_float`'s right span) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 14, 2024
Rollup merge of rust-lang#130294 - nnethercote:more-lifetimes, r=lcnr Lifetime cleanups The last commit is very opinionated, let's see how we go. r? `@oli-obk`
|
FWIW, how I got to this PR:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last commit is very opinionated, let's see how we go.
r? @oli-obk