Fix ICE when passing DefId-creating args to legacy_const_generics. #130443

veluca93 · 2024-09-16T18:23:51Z

r? BoxyUwU

Fixes #123077
Fixes #129150

compiler/rustc_ast_lowering/src/expr.rs

BoxyUwU · 2024-09-16T19:18:49Z

@bors try

bors · 2024-09-16T19:20:00Z

⌛ Trying commit 77a3a5e with merge 52464d1...

…r=<try> Fix ICE when passing DefId-creating args to legacy_const_generics. r? BoxyUwU Fixes rust-lang#123077

BoxyUwU · 2024-09-16T20:12:12Z

@bors try
(pushing commits cancels the try run xd)

…r=<try> Fix ICE when passing DefId-creating args to legacy_const_generics. r? BoxyUwU Fixes rust-lang#123077 Fixes rust-lang#129150

bors · 2024-09-16T20:13:23Z

⌛ Trying commit 193df11 with merge 47af3d0...

compiler/rustc_ast_lowering/messages.ftl

bors · 2024-09-16T21:59:52Z

☀️ Try build successful - checks-actions
Build commit: 47af3d0 (47af3d0de9d26c7deba4cfb203b710cc3f764e91)

compiler-errors · 2024-09-16T23:47:00Z

@craterbot check

craterbot · 2024-09-16T23:47:13Z

👌 Experiment pr-130443 created and queued.
🤖 Automatically detected try build 47af3d0
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

bors · 2024-09-22T01:21:40Z

☔ The latest upstream changes (presumably #130674) made this pull request unmergeable. Please resolve the merge conflicts.

craterbot · 2024-09-23T19:08:32Z

🚧 Experiment pr-130443 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2024-09-26T07:29:53Z

🎉 Experiment pr-130443 is completed!
📊 3 regressed and 0 fixed (513940 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

rfcbot · 2024-11-09T15:56:00Z

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

compiler/rustc_ast_lowering/messages.ftl

compiler/rustc_ast_lowering/src/expr.rs

rustbot · 2024-11-15T23:01:03Z

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

veluca93 · 2024-11-15T23:05:47Z

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged. Otherwise, you can ignore this comment.

That's from re-adding the pretty printer as a dep in rustc_ast_lowering.

BoxyUwU · 2024-11-16T01:21:35Z

@bors r+

bors · 2024-11-16T01:21:38Z

📌 Commit b462c68 has been approved by BoxyUwU

It is now in the queue for this repository.

…, r=BoxyUwU Fix ICE when passing DefId-creating args to legacy_const_generics. r? BoxyUwU Fixes rust-lang#123077 Fixes rust-lang#129150

bors · 2024-11-16T04:57:19Z

⌛ Testing commit b462c68 with merge 46e8d20...

bors · 2024-11-16T07:59:04Z

☀️ Test successful - checks-actions
Approved by: BoxyUwU
Pushing 46e8d20 to master...

RalfJung · 2024-11-16T08:04:06Z

compiler/rustc_ast_lowering/Cargo.toml

@@ -9,6 +9,7 @@ doctest = false
 [dependencies]
 # tidy-alphabetical-start
 rustc_ast = { path = "../rustc_ast" }
+rustc_ast_pretty = { path = "../rustc_ast_pretty" }


Was this already a transitive dep, or did this change reduce build parallelism?

It was a dep through rustc_errors (and it also was a direct dep ~10 days ago: b480f0f)

rust-timer · 2024-11-16T09:16:11Z

Finished benchmarking commit (46e8d20): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -2.3%, secondary -3.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.3%	[-2.3%, -2.3%]	1
Improvements ✅ (secondary)	-3.1%	[-3.1%, -3.1%]	1
All ❌✅ (primary)	-2.3%	[-2.3%, -2.3%]	1

Cycles

Results (secondary -10.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-10.3%	[-16.0%, -4.6%]	2
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 791.497s -> 788.11s (-0.43%)
Artifact size: 335.43 MiB -> 335.43 MiB (0.00%)

rustbot assigned BoxyUwU Sep 16, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 16, 2024

compiler-errors reviewed Sep 16, 2024

View reviewed changes

compiler/rustc_ast_lowering/src/expr.rs Show resolved Hide resolved

BoxyUwU reviewed Sep 16, 2024

View reviewed changes

compiler/rustc_ast_lowering/src/expr.rs Outdated Show resolved Hide resolved

veluca93 force-pushed the legacy-const-generics-fix branch from a598998 to 77a3a5e Compare September 16, 2024 19:02

bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 16, 2024

Auto merge of rust-lang#130443 - veluca93:legacy-const-generics-fix, …

52464d1

…r=<try> Fix ICE when passing DefId-creating args to legacy_const_generics. r? BoxyUwU Fixes rust-lang#123077

This comment has been minimized.

Sign in to view

veluca93 force-pushed the legacy-const-generics-fix branch from 77a3a5e to 193df11 Compare September 16, 2024 20:04

This comment has been minimized.

Sign in to view

klensy reviewed Sep 16, 2024

View reviewed changes

compiler/rustc_ast_lowering/messages.ftl Outdated Show resolved Hide resolved

craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 16, 2024

veluca93 force-pushed the legacy-const-generics-fix branch from 193df11 to 5c5e12f Compare September 17, 2024 07:55

This comment has been minimized.

Sign in to view

veluca93 force-pushed the legacy-const-generics-fix branch from 5c5e12f to 300d8f6 Compare September 17, 2024 09:13

This comment has been minimized.

Sign in to view

veluca93 force-pushed the legacy-const-generics-fix branch from 300d8f6 to ee70cbf Compare September 17, 2024 11:25

craterbot removed the S-waiting-on-crater Status: Waiting on a crater run to be completed. label Sep 26, 2024

veluca93 force-pushed the legacy-const-generics-fix branch from b4bd8fb to 44fb7f3 Compare November 5, 2024 18:30

rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. to-announce Announce this issue on triage meeting and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Nov 9, 2024

BoxyUwU reviewed Nov 15, 2024

View reviewed changes

compiler/rustc_ast_lowering/messages.ftl Outdated Show resolved Hide resolved

compiler/rustc_ast_lowering/src/expr.rs Outdated Show resolved Hide resolved

BoxyUwU added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-fcp Status: PR is in FCP and is awaiting for FCP to complete. labels Nov 15, 2024

veluca93 force-pushed the legacy-const-generics-fix branch from 44fb7f3 to c664250 Compare November 15, 2024 23:01

This comment has been minimized.

Sign in to view

veluca93 force-pushed the legacy-const-generics-fix branch from c664250 to 75552b3 Compare November 15, 2024 23:40

Fix ICE when passing DefId-creating args to legacy_const_generics.

b462c68

veluca93 force-pushed the legacy-const-generics-fix branch from 75552b3 to b462c68 Compare November 16, 2024 00:08

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 16, 2024

matthiaskrgr mentioned this pull request Nov 16, 2024

Rollup of 4 pull requests #133090

Closed

matthiaskrgr mentioned this pull request Nov 16, 2024

Rollup of 2 pull requests #133091

Closed

bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 16, 2024

bors merged commit 46e8d20 into rust-lang:master Nov 16, 2024
7 checks passed

rustbot added this to the 1.84.0 milestone Nov 16, 2024

RalfJung reviewed Nov 16, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix ICE when passing DefId-creating args to legacy_const_generics. #130443

Fix ICE when passing DefId-creating args to legacy_const_generics. #130443

veluca93 commented Sep 16, 2024 •

edited

Loading

BoxyUwU commented Sep 16, 2024

bors commented Sep 16, 2024

This comment has been minimized.

BoxyUwU commented Sep 16, 2024

bors commented Sep 16, 2024

This comment has been minimized.

bors commented Sep 16, 2024

compiler-errors commented Sep 16, 2024

craterbot commented Sep 16, 2024

This comment has been minimized.

This comment has been minimized.

bors commented Sep 22, 2024

craterbot commented Sep 23, 2024

craterbot commented Sep 26, 2024

rfcbot commented Nov 9, 2024

rustbot commented Nov 15, 2024

veluca93 commented Nov 15, 2024

This comment has been minimized.

BoxyUwU commented Nov 16, 2024

bors commented Nov 16, 2024

bors commented Nov 16, 2024

bors commented Nov 16, 2024

RalfJung Nov 16, 2024

veluca93 Nov 16, 2024

rust-timer commented Nov 16, 2024

Fix ICE when passing DefId-creating args to legacy_const_generics. #130443

Fix ICE when passing DefId-creating args to legacy_const_generics. #130443

Conversation

veluca93 commented Sep 16, 2024 • edited Loading

BoxyUwU commented Sep 16, 2024

bors commented Sep 16, 2024

This comment has been minimized.

BoxyUwU commented Sep 16, 2024

bors commented Sep 16, 2024

This comment has been minimized.

bors commented Sep 16, 2024

compiler-errors commented Sep 16, 2024

craterbot commented Sep 16, 2024

This comment has been minimized.

This comment has been minimized.

bors commented Sep 22, 2024

craterbot commented Sep 23, 2024

craterbot commented Sep 26, 2024

rfcbot commented Nov 9, 2024

rustbot commented Nov 15, 2024

veluca93 commented Nov 15, 2024

This comment has been minimized.

BoxyUwU commented Nov 16, 2024

bors commented Nov 16, 2024

bors commented Nov 16, 2024

bors commented Nov 16, 2024

RalfJung Nov 16, 2024

Choose a reason for hiding this comment

veluca93 Nov 16, 2024

Choose a reason for hiding this comment

rust-timer commented Nov 16, 2024

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

veluca93 commented Sep 16, 2024 •

edited

Loading