-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 9 pull requests #130530
Rollup of 9 pull requests #130530
Commits on Aug 22, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 363addc - Browse repository at this point
Copy the full SHA 363addcView commit details
Commits on Sep 3, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 6b0fc97 - Browse repository at this point
Copy the full SHA 6b0fc97View commit details
Commits on Sep 17, 2024
-
Implement ACP 429: add
Lazy{Cell,Lock}::get[_mut]
andforce_mut
In the implementation of `force_mut`, I chose performance over safety. For `LazyLock` this isn't really a choice; the code has to be unsafe. But for `LazyCell`, we can have a full-safe implementation, but it will be a bit less performant, so I went with the unsafe approach.
Configuration menu - View commit details
-
Copy full SHA for d0a2ca4 - Browse repository at this point
Copy the full SHA d0a2ca4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0fa92b4 - Browse repository at this point
Copy the full SHA 0fa92b4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3ecf8e9 - Browse repository at this point
Copy the full SHA 3ecf8e9View commit details
Commits on Sep 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 96a3b48 - Browse repository at this point
Copy the full SHA 96a3b48View commit details -
Revert "Add a hack to prevent proc_macro misopt in CI"
This reverts commit da8ac73.
Configuration menu - View commit details
-
Copy full SHA for 69350a4 - Browse repository at this point
Copy the full SHA 69350a4View commit details -
Configuration menu - View commit details
-
Copy full SHA for a18564c - Browse repository at this point
Copy the full SHA a18564cView commit details -
Do not ICE with incorrect empty suggestion
When we have two types with the same name, one without type parameters and the other with type parameters and a derive macro, we were before incorrectly suggesting to remove type parameters from the former, which ICEd because we were suggesting to remove nothing. We now gate against this. The output is still not perfect. E0107 should explicitly detect this case and provide better context, but for now let's avoid the ICE.
Configuration menu - View commit details
-
Copy full SHA for bd8e88f - Browse repository at this point
Copy the full SHA bd8e88fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 682c5f4 - Browse repository at this point
Copy the full SHA 682c5f4View commit details -
Configuration menu - View commit details
-
Copy full SHA for d9cdb71 - Browse repository at this point
Copy the full SHA d9cdb71View commit details -
Configuration menu - View commit details
-
Copy full SHA for f22797d - Browse repository at this point
Copy the full SHA f22797dView commit details -
compiler: Use make_indirect for the wasm ABI
This is ignored by LLVM, but is still incorrect.
Configuration menu - View commit details
-
Copy full SHA for 0cf89b5 - Browse repository at this point
Copy the full SHA 0cf89b5View commit details -
compiler: s/make_indirect_byval/pass_by_stack_offset/
The previous name is just an LLVMism, which conveys almost nothing about what is actually meant by the function relative to the ABI. In doing so, remove an already-addressed FIXME.
Configuration menu - View commit details
-
Copy full SHA for a800d1c - Browse repository at this point
Copy the full SHA a800d1cView commit details -
Configuration menu - View commit details
-
Copy full SHA for b75711d - Browse repository at this point
Copy the full SHA b75711dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 51718e8 - Browse repository at this point
Copy the full SHA 51718e8View commit details -
Rollup merge of rust-lang#97524 - ibraheemdev:thread-raw, r=ibraheemdev
Add `Thread::{into_raw, from_raw}` Public API: ```rust #![unstable(feature = "thread_raw", issue = "97523")] impl Thread { pub fn into_raw(self) -> *const (); pub unsafe fn from_raw(ptr: *const ()) -> Thread; } ``` ACP: rust-lang/libs-team#200
Configuration menu - View commit details
-
Copy full SHA for 8d52ab1 - Browse repository at this point
Copy the full SHA 8d52ab1View commit details -
Rollup merge of rust-lang#127988 - estebank:dupe-derive-params, r=fmease
Do not ICE with incorrect empty suggestion When we have two types with the same name, one without type parameters and the other with type parameters and a derive macro, we were before incorrectly suggesting to remove type parameters from the former, which ICEd because we were suggesting to remove nothing. We now gate against this. The output is still not perfect. E0107 should explicitly detect this case and provide better context, but for now let's avoid the ICE. Fix rust-lang#108748.
Configuration menu - View commit details
-
Copy full SHA for 1fa684f - Browse repository at this point
Copy the full SHA 1fa684fView commit details -
Rollup merge of rust-lang#129422 - compiler-errors:repr-rust, r=fmease
Gate `repr(Rust)` correctly on non-ADT items rust-lang#114201 added `repr(Rust)` but didn't add any attribute validation to it like `repr(C)` has, to only allow it on ADT items. I consider this code to be nonsense, for example: ``` #[repr(Rust)] fn foo() {} ``` Reminder that it's different from `extern "Rust"`, which *is* valid on function items. But also this now disallows `repr(Rust)` on modules, impls, traits, etc. I'll crater it, if it looks bad then I'll add an FCW. --- https://github.com/rust-lang/rust/labels/relnotes: Compatibility (minor breaking change).
Configuration menu - View commit details
-
Copy full SHA for 31e64b3 - Browse repository at this point
Copy the full SHA 31e64b3View commit details -
Rollup merge of rust-lang#129934 - ChrisDenton:remove-dir-all3, r=Ama…
…nieu Win: Open dir for sync access in remove_dir_all A small follow up to rust-lang#129800. We should explicitly open directories for synchronous access. We ultimately use `GetFileInformationByHandleEx` to read directories which should paper over any issues caused by using async directory reads (or else return an error) but it's better to do the right thing in the first place. Note though that `delete` does not read or write any data so it's not necessary there.
Configuration menu - View commit details
-
Copy full SHA for c83e1f6 - Browse repository at this point
Copy the full SHA c83e1f6View commit details -
Rollup merge of rust-lang#130450 - workingjubilee:these-names-are-ind…
…irect, r=bjorn3 Reduce confusion about `make_indirect_byval` by renaming it As part of doing so, remove the incorrect handling of the wasm target's `make_indirect_byval` (i.e. using it at all).
Configuration menu - View commit details
-
Copy full SHA for 3edd952 - Browse repository at this point
Copy the full SHA 3edd952View commit details -
Rollup merge of rust-lang#130476 - workingjubilee:more-lazy-methods-t…
…ake-2, r=Amanieu Implement ACP 429: add `Lazy{Cell,Lock}::get[_mut]` and `force_mut` Tracking issue for `lazy_get`: rust-lang#129333
Configuration menu - View commit details
-
Copy full SHA for 89610c0 - Browse repository at this point
Copy the full SHA 89610c0View commit details -
Rollup merge of rust-lang#130487 - cuviper:min-llvm-18, r=nikic
Update the minimum external LLVM to 18 With this change, we'll have stable support for LLVM 18 and 19. For reference, the previous increase to LLVM 17 was rust-lang#122649. cc `@rust-lang/wg-llvm` r? nikic
Configuration menu - View commit details
-
Copy full SHA for 66df252 - Browse repository at this point
Copy the full SHA 66df252View commit details -
Rollup merge of rust-lang#130513 - shekhirin:fs-write-doc-comment, r=…
…cuviper Clarify docs for std::fs::File::write This PR fixes the doc comment for `std::fs::File::write` method.
Configuration menu - View commit details
-
Copy full SHA for f0dc481 - Browse repository at this point
Copy the full SHA f0dc481View commit details -
Rollup merge of rust-lang#130522 - GnomedDev:clippy-manual-retain-pat…
…hs, r=compiler-errors [Clippy] Swap `manual_retain` to use diagnostic items instead of paths Part of rust-lang/rust-clippy#5393, just a chore.
Configuration menu - View commit details
-
Copy full SHA for 457c91c - Browse repository at this point
Copy the full SHA 457c91cView commit details