-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark make_ascii_uppercase
and make_ascii_lowercase
in [u8]
and str
as const.
#130738
Conversation
@rustbot label +T-libs-api -T-libs r? libs-api |
bf3dcd4
to
583862e
Compare
583862e
to
2daf076
Compare
|
bf3dcd4
to
74a7797
Compare
…in '[u8]' and 'str' as const;
74a7797
to
e723fe1
Compare
@bors r+ |
☀️ Test successful - checks-actions |
Finished benchmarking commit (11e760b): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)Results (primary 0.3%, secondary -1.4%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (primary 0.4%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeResults (primary -0.2%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Bootstrap: 768.999s -> 770.84s (0.24%) |
Relevant tracking issue: #130698
This PR extends #130697 and #130713 to the similar methods in byte slices (
[u8]
) and string slices (str
).For the
str
methods, this simply requires adding theconst
specifier to the function signatures. The[u8]
methods, however, require (at least a temporary) reimplementation due to the use of iterators andfor
loops.